Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 331554 - Remove Draw2d dependencies from AbstractEditPartViewer
Summary: Remove Draw2d dependencies from AbstractEditPartViewer
Status: RESOLVED WONTFIX
Alias: None
Product: GEF
Classification: Tools
Component: GEF-Legacy GEF (MVC) (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 minor (vote)
Target Milestone: ---   Edit
Assignee: gef-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-01 10:18 EST by Yuri CLA
Modified: 2014-03-04 15:28 EST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri CLA 2010-12-01 10:18:44 EST
Build Identifier: 20100917-0705

AbstractEditPartViewer is supposed to be base for various editors, including those not based on draw2d. A few methods of AbstractEditPartViewer are taking arguments of org.eclipse.draw2d.geometry.Point which creates a dependency on draw2d plugin.
If AbstractEditPartViewer is there to indeed let people implement their custom viewers this dependency should be eliminated. For example using swt point instead of draw2d point.

Reproducible: Always

Steps to Reproduce:
Just look into AbstractEditPartViewer class.
Comment 1 Alexander Nyßen CLA 2011-09-28 15:54:34 EDT
That is something we cannot change in the 3.x development stream to to API restrictions. However, in the GEF 4.0 branch we could remove those dependencies by porting GEF (MVC) to use the new Geometry API (developed in terms of bug #355997), which is independent from Draw2d.
Comment 2 Alexander Nyßen CLA 2012-03-11 14:58:59 EDT
Changed title to indicate this is a GEF4 topic. When porting to the new Geometry API, AbstractEditPartViewer should indeed not retain any dependencies on Draw2d.
Comment 3 Alexander Nyßen CLA 2014-03-04 15:28:05 EST
Within the newly provided GEF4 MVC component the transferred IVisualViewer is solely dependent on our own GEF4 Geometry API and does not have any Draw2d dependencies. As such, the problem is being resolved there. 

For GEF 3.x, resolving this as wont fix, as it implies an incompatible API change.