Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 331552 - [disassembly] Need a way to insert more than one source line
Summary: [disassembly] Need a way to insert more than one source line
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-debug-dsf (show other bugs)
Version: 7.0   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 7.0.2   Edit
Assignee: Anton Leherbauer CLA
QA Contact: Pawel Piech CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 331655
  Show dependency tree
 
Reported: 2010-12-01 10:12 EST by Anton Leherbauer CLA
Modified: 2010-12-02 07:23 EST (History)
1 user (show)

See Also:

Attachments
Small enhancement (9.68 KB, patch)
2010-12-02 06:48 EST, Anton Leherbauer CLA 		aleherb+eclipse: iplog-
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anton Leherbauer CLA 2010-12-01 10:12:18 EST 
Currently the disassembly view allows to insert at most one source line per instruction, but it would make sense to allow a range of source lines.
Comment 1 Anton Leherbauer CLA 2010-12-02 06:48:09 EST 
Created attachment 184340 [details]
Small enhancement

This enhances the IDisassemblyPartCallback interface by an additional method "insertSource" which allows to specify a line range (firstLine and lastLine) instead of a single line number.
Comment 2 Anton Leherbauer CLA 2010-12-02 07:05:22 EST 
Committed to cdt_7_0 and HEAD.
Comment 3 CDT Genie CLA 2010-12-02 07:23:03 EST 
*** cdt cvs genie on behalf of aleherbau ***
Bug 331552 - [disassembly] Need a way to insert more than one source line

[*] DisassemblyPart.java 1.31.2.6 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf/org.eclipse.cdt.dsf.ui/src/org/eclipse/cdt/dsf/debug/internal/ui/disassembly/DisassemblyPart.java?root=Tools_Project&r1=1.31.2.5&r2=1.31.2.6
[*] SourcePosition.java 1.1.2.1 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf/org.eclipse.cdt.dsf.ui/src/org/eclipse/cdt/dsf/debug/internal/ui/disassembly/SourcePosition.java?root=Tools_Project&r1=1.1&r2=1.1.2.1

[*] DisassemblyDocument.java 1.8.2.3 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf/org.eclipse.cdt.dsf.ui/src/org/eclipse/cdt/dsf/debug/internal/ui/disassembly/model/DisassemblyDocument.java?root=Tools_Project&r1=1.8.2.2&r2=1.8.2.3

[*] IDisassemblyPartCallback.java 1.1.2.1 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/disassembly/dsf/IDisassemblyPartCallback.java?root=Tools_Project&r1=1.1&r2=1.1.2.1

[*] IDisassemblyPartCallback.java 1.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt-debug/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/disassembly/dsf/IDisassemblyPartCallback.java?root=Tools_Project&r1=1.1&r2=1.2

[*] DisassemblyPart.java 1.42 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf/org.eclipse.cdt.dsf.ui/src/org/eclipse/cdt/dsf/debug/internal/ui/disassembly/DisassemblyPart.java?root=Tools_Project&r1=1.41&r2=1.42
[*] SourcePosition.java 1.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf/org.eclipse.cdt.dsf.ui/src/org/eclipse/cdt/dsf/debug/internal/ui/disassembly/SourcePosition.java?root=Tools_Project&r1=1.1&r2=1.2

[*] DisassemblyDocument.java 1.11 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf/org.eclipse.cdt.dsf.ui/src/org/eclipse/cdt/dsf/debug/internal/ui/disassembly/model/DisassemblyDocument.java?root=Tools_Project&r1=1.10&r2=1.11