Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 331486 - Open MPI launch configuration defaults not loaded
Summary: Open MPI launch configuration defaults not loaded
Status: RESOLVED FIXED
Alias: None
Product: PTP
Classification: Tools
Component: RM.Open MPI (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 5.0   Edit
Assignee: Greg Watson CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-30 19:29 EST by Greg Watson CLA
Modified: 2010-12-01 18:46 EST (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Greg Watson CLA 2010-11-30 19:29:36 EST
(First reported by Bob Fuhrer)

I noticed that when creating a new X10DT launch configuration using the OpenMPI transport using the launch configuration editor (as opposed to a launch shortcut), the Communication Interface page of the launch configuration editor showed invalid values. In particular, "Number of processes" was 0, and "Use default arguments" was unchecked, and the "Arguments" field was empty.

It seems this was because no one had called OpenMPILaunchConfigurationDefaults.loadDefaults() early enough.

The patch below calls loadDefaults() from BasicOpenMpiRMLaunchConfigurationDynamicTab.setDefaults(), and fixes the problem I was observing, but I'm not sure this is the right place to do that.

In fact, it seems odd that clients of OpenMPILaunchConfigurationDefaults should need to call OpenMPILaunchConfigurationDefaults.loadDefaults() at all. Shouldn't this be called from the bundle activator's startup() method? loadDefaults() seems to rely only on a bundle resource file, so it seems safe to call at bundle activation time.
Comment 1 Greg Watson CLA 2010-11-30 19:30:17 EST
Yes, it was missing from the plugin start method (the equivalent MPICH2 version is correct). I've added it now.

Thanks!