Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 331381 - Move JUnits that depend on Java SE 1.6 to new plugin that requires Java SE 1.6
Summary: Move JUnits that depend on Java SE 1.6 to new plugin that requires Java SE 1.6
Status: RESOLVED FIXED
Alias: None
Product: WTP Source Editing
Classification: WebTools
Component: wst.sse (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2.3   Edit
Assignee: Roberto Sanchez Herrera CLA
QA Contact: Nitin Dahyabhai CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-29 18:06 EST by Roberto Sanchez Herrera CLA
Modified: 2010-12-09 12:36 EST (History)
3 users (show)

See Also:
cbridgha: review+

Attachments
New plugin with execution environment Java SE 1.6 (215.62 KB, application/zip)
2010-11-29 18:06 EST, Roberto Sanchez Herrera CLA 		ccc: iplog+
Details
Move tests to new plugin (39.28 KB, patch)
2010-11-29 18:07 EST, Roberto Sanchez Herrera CLA 		no flags Details | Diff
Move tests to new plugin and add new plugin to wtp test feature (39.89 KB, patch)
2010-11-30 11:59 EST, Roberto Sanchez Herrera CLA 		ccc: iplog+
Details | Diff
The sourceediting feature change (655 bytes, patch)
2010-12-06 18:38 EST, Carl Anderson CLA 		ccc: iplog+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Roberto Sanchez Herrera CLA 2010-11-29 18:06:01 EST 
Build Identifier: M-3.2.3-20101129083231

Some JUnits (the import operations for JEE 6 modules and JEE 5 modules without deployment descriptor) need Java SE 1.6 in order to run correctly. If they run with Java SE 1.5, they fail. 

The patch and zip file attached to this defect are for creating a new plugin with Java SE 1.6 as the required execution environment, and for moving the JUnits that require Java SE 1.6 to this new plugin. 

Reproducible: Always
Comment 1 Roberto Sanchez Herrera CLA 2010-11-29 18:06:51 EST 
Created attachment 184085 [details]
New plugin with execution environment Java SE 1.6
Comment 2 Roberto Sanchez Herrera CLA 2010-11-29 18:07:46 EST 
Created attachment 184086 [details]
Move tests to new plugin
Comment 3 David Williams CLA 2010-11-29 18:20:45 EST 
Maybe this has already been discussed within your team, but I have to ask ... why move them? Why not move the whole test suite to require Java 6? We've been using Java 6 to run our JUnit tests for some time now ... 2 years? ... and moving forward, Java 6 will be more officially minimum runtime level.
Comment 4 Carl Anderson CLA 2010-11-29 21:41:14 EST 
My two cents - we should have three different plugins with three different required JREs - all of the J2SE-1.4 through J2SE-1.6 - for running each of the different types of tests.  The J2SE level would match the Java EE level.

However, I would also be fine with moving all of the tests up to require J2SE-1.6.  The important part is that the Java EE 6 tests need J2SE-1.6
Comment 5 Chuck Bridgham CLA 2010-11-30 11:57:48 EST 
I vote for this plugin at this time.

Our requirements dictate that we run in backlevel java for most of our tests because the majority of our customers run in older legacy servers with Java 5 etc....

For now - having a separate java 6 test plugin for newer tests/scenarios makes sense to run them emulating the customer environment.
Comment 6 Roberto Sanchez Herrera CLA 2010-11-30 11:59:57 EST 
Created attachment 184148 [details]
Move tests to new plugin and add new plugin to wtp test feature

New patch to include the new plugin into the WTP test feature
Comment 7 Chuck Bridgham CLA 2010-11-30 20:36:19 EST 
approve
Comment 8 Carl Anderson CLA 2010-12-06 18:38:45 EST 
Created attachment 184677 [details]
The sourceediting feature change
Comment 9 Carl Anderson CLA 2010-12-06 18:53:24 EST 
Since the org.eclipse.jst.web_tests.feature is in sourceediting, we will need to involve the sourceediting team
Comment 10 Carl Anderson CLA 2010-12-06 23:23:03 EST 
The new plugin has been created and Roberto's initial patch is now committed/released to both R3_2_maintenance and HEAD for WTP 3.2.3 and WTP 3.3.  The sourceediting feature change still needs to be committed/released, so I am transferring this bug to them.
Comment 11 Nitin Dahyabhai CLA 2010-12-07 16:25:21 EST 
Attachment 184677 [details] release released to 3.2.3.
Comment 12 Nitin Dahyabhai CLA 2010-12-07 16:30:07 EST 
And to 3.3.
Comment 13 Carl Anderson CLA 2010-12-09 12:36:33 EST 
As per Nitin's previous comments, the test feature patch was committed/released to both R3_2_maintenance and HEAD for WTP 3.2.3 and WTP 3.3.