Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 331368 - Dependency from org.eclipse.jst.j2ee.tests to org.eclipse.jst.jsf.test.util should be removed
Summary: Dependency from org.eclipse.jst.j2ee.tests to org.eclipse.jst.jsf.test.util s...
Status: RESOLVED FIXED
Alias: None
Product: WTP Java EE Tools
Classification: WebTools
Component: jst.j2ee (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P2 normal (vote)
Target Milestone: 3.2.3   Edit
Assignee: Roberto Sanchez Herrera CLA
QA Contact: Chuck Bridgham CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-29 13:07 EST by Roberto Sanchez Herrera CLA
Modified: 2010-12-01 19:26 EST (History)
3 users (show)

See Also:
cbridgha: review+

Attachments
Patch to remove the dependency of jsf tests (3.81 KB, patch)
2010-11-29 14:59 EST, Roberto Sanchez Herrera CLA 		dimitar.giormov: iplog+
Details | Diff
Zip used in the test (7.23 KB, application/zip)
2010-11-29 15:02 EST, Roberto Sanchez Herrera CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Roberto Sanchez Herrera CLA 2010-11-29 13:07:08 EST 
Build Identifier: M-3.2.3-20101129083231

As part of the work made in bugzilla 323185, a dependency from plugin org.eclipse.jst.j2ee.tests to org.eclipse.jst.jsf.test.util was added, in order to call a method to unzip projects from a zip file. 

The plugin org.eclipse.jst.j2ee.tests already has a class that do that (take a look at org.eclipse.jst.j2ee.flexible.project.fvtests.J2EEFlexProjDeployablePerfTest, which uses org.eclipse.etools.common.test.apitools.ProjectUnzipUtil to unzip projects).

The class org.eclipse.jst.jee.model.web.tests.TestWebXmlModelAfterUpdate should be changed to use ProjectUnzipUtil  instead of org.eclipse.jst.jsf.test.util.TestUtil and the dependency should be removed

Reproducible: Always
Comment 1 Carl Anderson CLA 2010-11-29 13:10:42 EST 
The j2ee tests are utilized in an adopter product.  As such, we wish to maintain the j2ee tests dependencies along the same lines as the j2ee plugin dependencies.
Since the additional JSF tests dependencies could cause adoption issues, I am raising this to a P2.
Comment 2 Roberto Sanchez Herrera CLA 2010-11-29 14:59:18 EST 
Created attachment 184070 [details]
Patch to remove the dependency of jsf tests
Comment 3 Roberto Sanchez Herrera CLA 2010-11-29 15:02:15 EST 
Created attachment 184074 [details]
Zip used in the test

I had to work a little on this attachment, to include the "root" project folder. This file must be placed in folder TestData/WebEditDdExternal in plugin org.eclipse.jst.j2ee.tests
Comment 4 Chuck Bridgham CLA 2010-11-30 20:33:39 EST 
approve
Comment 5 Carl Anderson CLA 2010-12-01 19:26:03 EST 
Committed to R3_2_maintenance and HEAD for WTP 3.2.3 and WTP 3.3