Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 331363 - [Build] Spring-clean in BuildManager
Summary: [Build] Spring-clean in BuildManager
Status: RESOLVED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Resources (show other bugs)
Version: 3.7   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-Resources-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-29 12:29 EST by Szymon Brandys CLA
Modified: 2013-03-13 10:33 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Szymon Brandys CLA 2010-11-29 12:29:52 EST 
While working on BuildConfigurations nad Context, we noticed with James that BuildManager is far too complicated for what it does. 
The first think is the number of various basicBuild methods. Let's try to look at later in the 3.7 cycle.
Comment 1 John Arthorne CLA 2013-03-12 09:11:33 EDT 
I think BuildManager does exactly what it needs to do, and no more :) Smaller methods could be inlined to make bigger methods but I don't think it buys much benefit. This is worth revisiting only if we start doing more new feature work in here.
Comment 2 Szymon Brandys CLA 2013-03-13 10:33:13 EDT 
(In reply to comment #1)
> I think BuildManager does exactly what it needs to do, and no more :)
> Smaller methods could be inlined to make bigger methods but I don't think it
> buys much benefit. This is worth revisiting only if we start doing more new
> feature work in here.

True.