Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 331349 - [Compatibility] SaveablesList leaks workbench parts when parts are not closed using 3.x APIs
Summary: [Compatibility] SaveablesList leaks workbench parts when parts are not closed...
Status: RESOLVED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 1.0   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: 4.1 M4   Edit
Assignee: Remy Suen CLA
QA Contact: Remy Suen CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-29 11:04 EST by Remy Suen CLA
Modified: 2010-11-29 11:05 EST (History)
0 users

See Also:

Attachments
WorkbenchPage patch v1 (1.19 KB, patch)
2010-11-29 11:04 EST, Remy Suen CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2010-11-29 11:04:11 EST 
We have some copy/paste in our 3.x API implementations but when parts are closed via e4 APIs, the code path currently doesn't go through the SaveablesList so we end up leaking the parts.
Comment 1 Remy Suen CLA 2010-11-29 11:04:50 EST 
Created attachment 184045 [details]
WorkbenchPage patch v1
Comment 2 Remy Suen CLA 2010-11-29 11:05:26 EST 
Fixed in CVS HEAD.