Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 331336 - [releng] generate source features
Summary: [releng] generate source features
Status: RESOLVED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: Search (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Danail Branekov CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 331272
Blocks:
  Show dependency tree
 
Reported: 2010-11-29 08:29 EST by Paul Webster CLA
Modified: 2011-08-11 03:30 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Webster CLA 2010-11-29 08:29:31 EST
You can add sources features for your main feature and example feature, so that developers can install source when installing your plugins.

See our SDK feature.xml/build.properties and one of our regular features for an example.  Setup to generate source features, could be added to your master feature:

http://dev.eclipse.org/viewcvs/viewvc.cgi/e4/org.eclipse.e4.ui/features/org.eclipse.e4.sdk.source.feature/feature.xml?view=co&content-type=text/plain

http://dev.eclipse.org/viewcvs/viewvc.cgi/e4/org.eclipse.e4.ui/features/org.eclipse.e4.sdk.source.feature/build.properties?view=co

An example feature with template directories for the source features/plugins:

http://dev.eclipse.org/viewcvs/viewvc.cgi/e4/org.eclipse.e4.ui/features/org.eclipse.e4.ui.css.feature/

PW
Comment 1 Danail Branekov CLA 2011-08-04 10:00:08 EDT
Paul, I have committed the required changes in GIT and tagged them as v20110711-1000. The tag is added to the search map file. I have also updated the e4-category.xml file in org.eclipse.e4.builder project in CVS in order to include the source feature in the E4 Search category.

In order to test whether source bundles generation works I have exported the master feature as deployable feature thus effectively creating a local repository. Using the software update tooling I saw that the source feature is available there.

However, with the latest available 0.12 p2 repo I don't find the search source feature. I have obviously missed to do something. Can you give me a hand in understanding what?

Thanks!
Comment 2 Paul Webster CLA 2011-08-08 10:29:19 EDT
Andrew, can you give them a hand?  They're trying to get their source feature in order.

PW
Comment 3 Andrew Niefer CLA 2011-08-08 15:46:49 EDT
I think the new source feature just needed to be added to the e4.sdk.source feature so that it gets included in the build.

http://git.eclipse.org/c/e4/org.eclipse.e4.ui.git/commit/?id=22f6b8b128059692027bcdf3ebae96cef1965e9d
Comment 4 Danail Branekov CLA 2011-08-11 03:30:21 EDT
Thanks, Andrew, this did the trick

As the source bundles are now part of the E4 repo, I am closing this issue as fixed