Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 331319 - PackFile has dead code
Summary: PackFile has dead code
Status: RESOLVED FIXED
Alias: None
Product: JGit
Classification: Technology
Component: JGit (show other bugs)
Version: 0.10.0   Edit
Hardware: All All
: P3 trivial (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-29 06:06 EST by Remy Suen CLA
Modified: 2010-12-01 13:01 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2010-11-29 06:06:59 EST 
The local variable 'shift' is never used on lines 761 and 765. It should either be used for something or be deleted.

See org.eclipse.jgit.storage.file.PackFile's getObjectType(WindowCursor, long) method.
Comment 1 Shawn Pearce CLA 2010-12-01 13:01:37 EST 
Thanks Remy.  I've pushed commit d29b5db695225ed9629b028f99070bd182320b0f to remove the unnecessary shift variable in getObjectType().