Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 331305 - e4 messed up my toplevel menus and workbench
Summary: e4 messed up my toplevel menus and workbench
Status: CLOSED DUPLICATE of bug 331441
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 331440
  Show dependency tree
 
Reported: 2010-11-29 04:12 EST by Martin Oberhuber CLA
Modified: 2010-12-14 04:14 EST (History)
2 users (show)

See Also:


Attachments
Zipped Log (10.92 KB, application/zip)
2010-11-29 04:12 EST, Martin Oberhuber CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Oberhuber CLA 2010-11-29 04:12:30 EST
Created attachment 184011 [details]
Zipped Log

Build ID: SDK 4.1 M3

I've been using Eclipse 4.1m3 for a while, and just now the 2nd time my Workbench got messed up. First of all, the "Search" toplevel menu went missing; instead I saw a "Design" menu that I couldn't use. 

Then, after installing an additional harmless plugin and restarting, my views wouldn't open any more. At this point, I was locked out (quit / restart wouldn't help). I deleted my .metadata/.plugins/org.eclipse.e4.workbench/deltas.xml file to get going again. 
  
Attached is my .log for a start, not sure whether it will help. 
The "Search" menu is still missing and I don't know how to get it back.
Comment 1 Remy Suen CLA 2010-11-29 11:11:34 EST
(In reply to comment #0)
> Attached is my .log for a start, not sure whether it will help. 
> The "Search" menu is still missing and I don't know how to get it back.

So you mean it's gone despite deleting the deltas.xml file, correct?
Comment 2 Martin Oberhuber CLA 2010-11-29 12:40:41 EST
Yes, exactly. And without "Customize Perspective" I don't know how to get it back.
Comment 3 Remy Suen CLA 2010-11-29 12:42:18 EST
I think it probably means there are plug-ins conflicting with each other or something then.
Comment 4 Martin Oberhuber CLA 2010-11-29 13:43:03 EST
How would I find out?

I _think_ that the Search menu was initially there in that workspace (I'd be surprised if I found out so late after working there for a while).
Comment 5 Remy Suen CLA 2010-11-29 13:49:06 EST
(In reply to comment #4)
> How would I find out?

To be honest, I'm not sure. If you have the 'Package Explorer' view active, the menu should appear. The only reason I can think of for the menu not appearing is if we're not activating certain contexts for some reasons.
Comment 6 Eric Moffatt CLA 2010-11-29 15:08:08 EST
Martin, what perspective were you in when you noticed the missing Search ?

My thought is that we may still have some ActionSet issues...one way to check might be to start with the Java Perspective open and see if the Search menu is there, then open the one you were using and see if it comes/goes based on the perspective.
Comment 7 Mike Wilson CLA 2010-11-29 16:09:20 EST
This falls into the category of "e4 needs to be more robust". Ideally, what we should be shooting for is having 4.x be *more* robust than 3.x. I.e. It should be extremely difficult to get in a state where views don't open, etc. 

Martin, from the sounds of it, I guess the answer to this question is probably no, but: Can you recreate this failure? Does adding the "harmless plugin" normally work?
Comment 8 Remy Suen CLA 2010-11-29 16:13:13 EST
(In reply to comment #0)
> Then, after installing an additional harmless plugin and restarting, my views
> wouldn't open any more.

What exactly happened when you tried to open the views, by the way? In the logs, I don't see any mention of "showView" and only one mention of "showPart" (for an editor). Or did you mean the entire workbench window was just "blank" with only tab items with text and images?
Comment 9 Martin Oberhuber CLA 2010-11-30 00:24:24 EST
Hm, let me see what I can answer:

- My workspace is old. Had been using the same in Eclipse 3.x then copied and
  started using 4.x on it. Had 4.x deadlocks (Bug 323808, Remy knows more).
  That being said, it's unlikely I can reproduce this. Setting up my 
  workspace is a sizeable amount of work. But given I'm messed up at the 
  moment I might do it. Though that's what I (as a consumer) is exactly what
  I'd like to avoid. If I'm messed up I'd like to repair my workspace without
  setting all up again.

- My log is incomplete, I had deleted it at times (had to, since it grew to
  5 files of 20MB each when the bug 323808 view recursion happened).

- I typically use these perspectives: JDT (primary), Synchronize (2nd), 
  sometimes RSE, Resource, PDE. I can't tell where the Search menu went
  missing first, but at the moment it's gone in all perspectives.

- I can still Window > Show View..Search and "Open Search Dialog" from the
  empty Search view.

- The "harmless plugin" was an I-build update to RSE+Terminal which I had
  successfully installed before. Some odd dependency problem due to feature
  inclusion is not completely impossible. RSE does contribute to the Search
  menu. But given that Search does work (see above) is this realistic?

- Did I sometimes have views completely empty? Yes. That's when everything was
  locked up. That problem went away after deleting deltas.xml.

As I'm likely going to setup my workspace from scratch again, here's what I am really looking for: Advice what I should do or not in order to 
  - get the most stable environment
  - get out of trouble just in case
  - log everything the e4 team needs to investigate issue.
For instance, will it help when I never delete my .log ? Zip up my entire workspace in case a problem happens? Archive the workspace before I delete a log? What are typical indications of e4 "illness" to watch out for such that I can react early? Can we advise people that copying their 3.x workspace is OK or should they start from scratch?
Comment 10 Remy Suen CLA 2010-11-30 07:56:04 EST
(In reply to comment #0)
> Then, after installing an additional harmless plugin and restarting, my views
> wouldn't open any more.

(In reply to comment #9)
> - I can still Window > Show View..Search and "Open Search Dialog" from the
>   empty Search view.

So based on comment 0 and comment 9, do you mean to say that the 'Search' view is the only view that will open now? I am interested in what views fail to come up and why. Do the tab items get created at least? Does the tab folder switch its selection to that view's tab?

> - The "harmless plugin" was an I-build update to RSE+Terminal which I had
>   successfully installed before. Some odd dependency problem due to feature
>   inclusion is not completely impossible. RSE does contribute to the Search
>   menu. But given that Search does work (see above) is this realistic?

I think it would depend on how it's contributing these entries...dependent on whether it defines expressions or whatever which have inadvertently caused it to always return 'false', hence, making it hidden "forever".

> - Did I sometimes have views completely empty? Yes.

I presume this happened when you were attempting to shutdown Eclipse?

> For instance, will it help when I never delete my .log ?

This is a difficult question. I think it would be valuable if the logs were renamed before the installation of a plug-in though as that would help differentiate the two states more succinctly.

> Zip up my entire
> workspace in case a problem happens? Archive the workspace before I delete a
> log? What are typical indications of e4 "illness" to watch out for such that I
> can react early? Can we advise people that copying their 3.x workspace is OK or
> should they start from scratch?

Personally, I don't really feel that the workspace is going to be the cause of problems. It should only become a concern if you have deleted your deltas.xml and 4.x _still_ will not open on your existing workspace yet it _does_ open on a _new_ workspace.

The only times I feel workspace settings are going to kick in is say you have a view with some (custom) filters and the 4.x code isn't handling it well and the view dies as a result. However, on a new workspace you haven't had the chance to reconfigure your view with your filters yet so it opens happily.
Comment 11 Martin Oberhuber CLA 2010-11-30 08:09:01 EST
(In reply to comment #10)
> I am interested in what views fail to come

No views came up at all, everything was blank. Then I deleted deltas.xml, now the views (including search view) come up again. Workbench is quite usable -- only the "Search" menu remains gone.
Comment 12 Remy Suen CLA 2010-11-30 09:13:27 EST
(In reply to comment #9)
> - The "harmless plugin" was an I-build update to RSE+Terminal which I had
>   successfully installed before.

Which update site do I use for this, by the way?

Or is the 3.3 milestones update site good enough?
http://download.eclipse.org/dsdp/tm/updates/3.3milestones
Comment 13 Martin Oberhuber CLA 2010-11-30 09:16:17 EST
Yes, 3.3milestones is fine.
Comment 14 Remy Suen CLA 2010-11-30 09:46:51 EST
(In reply to comment #13)
> Yes, 3.3milestones is fine.

Thanks, Martin.

I have reproduced the 'Search' menu problem. See bug 331440 and bug 331441.
Comment 15 Martin Oberhuber CLA 2010-12-14 04:14:12 EST
(In reply to comment #14)
Since bug 331441 now tracks the "Search" menu problem, I feel like this bug can be closed. I have started a fresh workspace from scratch with Eclipse 4.1m4 and will open a new bug (with hopefully better logs) in case something bad happens again.

*** This bug has been marked as a duplicate of bug 331441 ***