Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 331259 - [Compatibility] 3.x commands no longer have states available to them
Summary: [Compatibility] 3.x commands no longer have states available to them
Status: RESOLVED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 1.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.1 M4   Edit
Assignee: Paul Webster CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 331240
  Show dependency tree
 
Reported: 2010-11-26 18:09 EST by Remy Suen CLA
Modified: 2010-11-29 11:43 EST (History)
2 users (show)

See Also:

Attachments
Fix command parameters and command state (44.23 KB, patch)
2010-11-29 11:41 EST, Paul Webster CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2010-11-26 18:09:17 EST 
A large majority of the EGit views will not work because it can't initialize a RepositoriesViewContentProvider as the Command is returning null for getState(String).

Caused by the changes to CommandPersistence for bug 329646.

java.lang.NullPointerException
    at
org.eclipse.egit.ui.internal.repository.RepositoriesViewContentProvider.<init>(RepositoriesViewContentProvider.java:87)
    at
org.eclipse.egit.ui.internal.clone.GitSelectRepositoryPage.createControl(GitSelectRepositoryPage.java:96)
    at org.eclipse.jface.wizard.Wizard.createPageControls(Wizard.java:170)
Comment 2 Paul Webster CLA 2010-11-29 11:41:52 EST 
Created attachment 184053 [details]
Fix command parameters and command state
Comment 3 Paul Webster CLA 2010-11-29 11:43:09 EST 
Fill in the model with as much information as it can handle.  Then in the compatibility layer, add extra information that the Compay layer needs.

Released
PW