Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 331142 - [backport] RSE SystemView logs a reentrant call
Summary: [backport] RSE SystemView logs a reentrant call
Status: RESOLVED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: 3.2.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2.2   Edit
Assignee: Martin Oberhuber CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords:
Depends on: 330386
Blocks:
  Show dependency tree
 
Reported: 2010-11-25 12:17 EST by Martin Oberhuber CLA
Modified: 2011-02-01 08:03 EST (History)
4 users (show)

See Also:
dmcknigh: review+


Attachments
Log with backtrace (14.84 KB, text/plain)
2010-11-25 12:17 EST, Martin Oberhuber CLA
no flags Details
backported patch (2.26 KB, patch)
2011-01-26 04:03 EST, Martin Oberhuber CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Oberhuber CLA 2010-11-25 12:17:03 EST
Created attachment 183869 [details]
Log with backtrace

+++ This bug was initially created as a clone of Bug #330386 +++

I just found TM 3.1.1 logging the message "Ignored reentrant call while viewer is busy. This is only logged once per viewer instance, but similar calls will still be ignored." along with a backtrace identifying the SystemView (attached).

I think we should backport the fix for bug 330386 to TM 3.1.2 since I assume it will fix these kinds of problems.
Comment 1 Martin Oberhuber CLA 2010-11-25 12:30:42 EST
CQ:WIND00241753  
Will look at the backtrace in more detail
Comment 2 Martin Oberhuber CLA 2010-11-25 15:58:55 EST
Comment on attachment 183869 [details]
Log with backtrace

The backtrace does not show an RSE problem, still it may be interesting to perform the backport of the fix which was necessary for Eclipse 4.1.
Comment 3 Martin Oberhuber CLA 2011-01-26 04:03:13 EST
Created attachment 187616 [details]
backported patch

Dave M, can you give your +1 on this patch please
Comment 4 David McKnight CLA 2011-01-26 15:30:25 EST
(In reply to comment #3)
> Created attachment 187616 [details]
> backported patch
> 
> Dave M, can you give your +1 on this patch please

The patch looks good to me.
Comment 5 Martin Oberhuber CLA 2011-02-01 08:03:25 EST
Committed into 3.2.2 RC2