Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 331073 - Cache strings read from object file
Summary: Cache strings read from object file
Status: CLOSED FIXED
Alias: None
Product: RTSC
Classification: Technology
Component: Rta (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Chris McCormick CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-24 18:24 EST by Chris McCormick CLA
Modified: 2011-11-09 18:55 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris McCormick CLA 2010-11-24 18:24:06 EST 
To improve RTA / ROV performance when repeatedly reading the same printf string from the COFF / ELF file, the strings should be cached when found.

This can be done in the OFReader implementations themselves, or somewhere higher in the stack.
Comment 1 Chris McCormick CLA 2010-12-06 18:08:33 EST 
Fixed in xdctargets-d10.

Used a HashMap to store the mapping of address-to-string. 

Didn't add this caching to the version of findString which takes a specific section name; ROV and RTA currently don't call this other API. This would require a separate Section -> Address -> String map (or Address -> Section -> String).
Comment 2 Dave Russo CLA 2011-11-09 18:55:37 EST 
closing "ancient" resolved bugs