Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 331047 - Using PartState.CREATE to show a part with EPartService should adjust the placeholder before the rendering request
Summary: Using PartState.CREATE to show a part with EPartService should adjust the pla...
Status: RESOLVED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 1.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.1 M4   Edit
Assignee: Remy Suen CLA
QA Contact: Remy Suen CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-24 12:25 EST by Remy Suen CLA
Modified: 2010-11-24 12:27 EST (History)
0 users

See Also:


Attachments
EPartService patch v1 (3.95 KB, patch)
2010-11-24 12:26 EST, Remy Suen CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2010-11-24 12:25:36 EST
As is, the code will just try to render the part without considering the fact that the part may not be pointing at its local placeholder.

This can cause problems as renderer implementations have a tendency to try to ask the element for its parent or its placeholder. In this case, both methods will return 'null' for a shared part that doesn't have its placeholder adjusted.
Comment 1 Remy Suen CLA 2010-11-24 12:26:59 EST
Created attachment 183784 [details]
EPartService patch v1
Comment 2 Remy Suen CLA 2010-11-24 12:27:26 EST
Fixed in CVS HEAD.