Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 331014 - Synchronize Git doesn't allow a finish
Summary: Synchronize Git doesn't allow a finish
Status: CLOSED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 0.10.0   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-24 09:12 EST by Paul Webster CLA
Modified: 2011-07-14 17:54 EDT (History)
2 users (show)

See Also:

Attachments
Sync dialog dead-end (44.75 KB, image/png)
2010-11-24 09:12 EST, Paul Webster CLA 		no flags Details
synchronize wizard with warning (15.81 KB, image/png)
2011-06-14 15:35 EDT, Dariusz Luksza CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Webster CLA 2010-11-24 09:12:34 EST 
Created attachment 183756 [details]
Sync dialog dead-end

I installed the nightlies in the latest 3.7 I build:
org.eclipse.egit.feature.group 0.10.0.201011231519
Eclipse Build: I20101123-0800

I loaded up a git repo, made a change, and went to the Team Sync perspective/Sync view.

I clicked on the sync button (since the view was empty), picked Git, and worked my way thought the next buttons.

Now I'm on a screen that allows me to pick my projects, but I can never go forward or select Finish.

I've tried de-select all/select all, picking only one project, etc.

PW
Comment 1 Pavel Sklenak CLA 2010-12-31 08:51:26 EST 
You have to select branch first. I was confused too. I took me few months than I realized how it works ;) Maybe HEAD should be selected as default.

However, synchronize view has terrible performance problems so it isn't usable yet.
Comment 2 Dariusz Luksza CLA 2011-06-13 15:06:38 EDT 
Could you please check this on newest version of EGit?
Comment 3 Pavel Sklenak CLA 2011-06-14 01:35:13 EDT 
Dariusz, I tracked sync view performance for long period of time but now it is even faster. I especially appreciate Synchronize Workspace command ;)

"Team - Synchronize - Custom..." dialog has still finish button inactive. I see there is better description ("Select destination for repositories to be synchronized.") so I don't know if the bug is still relevant. I suggest to use IStatus.WARNING style (with warning picture) for above mentioned status and close the bug.
Comment 4 Paul Webster CLA 2011-06-14 08:06:57 EDT 
I don't seem to have any problems on 1.1.0 nightlies, it might be  as Pavel said my first git attempts weren't fully configured.

PW
Comment 5 Dariusz Luksza CLA 2011-06-14 15:35:32 EDT 
Created attachment 197975 [details]
synchronize wizard with warning
Comment 6 Dariusz Luksza CLA 2011-06-14 15:36:30 EDT 
(In reply to comment #3)
> "Team - Synchronize - Custom..." dialog has still finish button inactive. I see
> there is better description ("Select destination for repositories to be
> synchronized.") so I don't know if the bug is still relevant. I suggest to use
> IStatus.WARNING style (with warning picture) for above mentioned status and
> close the bug.

Good suggestion. I've attached how this wizard could look like with this modification and I'll push this change in a minute to gerrit.
Comment 7 Dariusz Luksza CLA 2011-07-07 20:25:17 EDT 
Here is change mentioned before:
http://egit.eclipse.org/r/3853
Comment 8 Dariusz Luksza CLA 2011-07-14 17:54:27 EDT 
merged as 6c23c273b51fca1f5d81051b62f22dbdac77f83e