Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 330989 - [dstore] OutOfMemoryError occurs when searching for a text in a large remote file
Summary: [dstore] OutOfMemoryError occurs when searching for a text in a large remote ...
Status: RESOLVED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3 M4   Edit
Assignee: David McKnight CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 331366 331367
  Show dependency tree
 
Reported: 2010-11-24 00:31 EST by Masao Nishimoto CLA
Modified: 2010-11-29 13:09 EST (History)
1 user (show)

See Also:


Attachments
patch to not read large file all at once (2.71 KB, patch)
2010-11-24 09:32 EST, David McKnight CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Masao Nishimoto CLA 2010-11-24 00:31:44 EST
UniversalSearchHandler.simpleSearch() tries to read all at once.  If the file size is more than the half of free heap size, it always causes the OutOfMemory.
Comment 1 David McKnight CLA 2010-11-24 09:32:41 EST
Created attachment 183759 [details]
patch to not read large file all at once
Comment 2 David McKnight CLA 2010-11-24 09:33:20 EST
Masao, could you try this patch?
Comment 3 Masao Nishimoto CLA 2010-11-24 19:48:15 EST
I tested the patch, and confirmed that no OutOfMemoryError occurred.
Comment 4 David McKnight CLA 2010-11-25 09:37:23 EST
I've committed the change to cvs.  Does this need to be backported?
Comment 5 Masao Nishimoto CLA 2010-11-25 19:11:37 EST
Yes, please back port to 3.0.3 and 3.2.