Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 330963 - edc - DWARF - scope highAddr fixup performance improvement
Summary: edc - DWARF - scope highAddr fixup performance improvement
Status: RESOLVED WONTFIX
Alias: None
Product: CDT
Classification: Tools
Component: cdt-debug-edc (show other bugs)
Version: 7.0.1   Edit
Hardware: All SymbianOS S60
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Ken Ryall CLA
QA Contact: Ken Ryall CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-23 14:19 EST by Kirk Beitz CLA
Modified: 2019-12-30 18:39 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kirk Beitz CLA 2010-11-23 14:19:45 EST 
the originally committed fix for the case where the compiler fixes up a scope highAddr that is less than the scope lowAddr made use of the separate package ModuleLineEntryProvider to get the line-number information.

but the reader already maintains the currentCompileUnitScope, and the line info associated with that is already scoped by address to be in the same range as the scope highAddr we are attempting to fix up.

the attached patch used the currentCompileUnitScope line entries, which:
a] pre-parses a lot less of the LNT to get the smaller set of entries needed
b] removes the dependency on ModuleLineEntryProvider (and its inefficiencies)

currently, this fix (not to mention the overriding bug that led to the original fix) is only known to affect DWARF generation for the symbian compiler, though the fix should be appropriate for any case where the LNT info is correct but the high address for the scope is calculated to be less than the low address.
Comment 1 Daniel Thomas CLA 2011-08-30 10:19:29 EDT 
Fixed in http://git.eclipse.org/c/cdt/org.eclipse.cdt.edc.git/commit/?id=c1153ae0b723005dbccf6251064d4d4b0ae22731 (though I can't change the status on this bug)
Comment 2 Jonah Graham CLA 2019-12-30 18:39:50 EST 
(this is part of a batch change)

The Eclipse CDT EDC (https://wiki.eclipse.org/CDT/cdt-debug-edc) is now obsolete and has not had any active development since 2011. Therefore the still open bugs are being marked as wontfix.

The git repo for the project still exists for posterity at https://git.eclipse.org/c/cdt/org.eclipse.cdt.edc.git/