Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 330950 - edc - disassembly - code cleanup in EDCInstruction.java
Summary: edc - disassembly - code cleanup in EDCInstruction.java
Status: RESOLVED WONTFIX
Alias: None
Product: CDT
Classification: Tools
Component: cdt-debug-edc (show other bugs)
Version: 7.0.1   Edit
Hardware: All All
: P3 trivial (vote)
Target Milestone: ---   Edit
Assignee: Ken Ryall CLA
QA Contact: Ken Ryall CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-23 13:09 EST by Kirk Beitz CLA
Modified: 2019-12-30 18:39 EST (History)
1 user (show)

See Also:

Attachments
patch for EDCInstruction 1.6 : code cleanup changes (1.76 KB, patch)
2010-11-23 13:09 EST, Kirk Beitz CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kirk Beitz CLA 2010-11-23 13:09:25 EST 
Created attachment 183689 [details]
patch for EDCInstruction 1.6 : code cleanup changes

for HEAD, the following changes apply (and are found in the attachment)

1] the import of IInstruction is no longer necessary
2] javaDoc from AbstractInstruction is sufficient for getSize()
3] AbstractInstruction#getSize() lends to use of @Oversize here

for CDT_7_0, the following is the only change necessary

1] the import of IInstruction is no longer necessary
Comment 1 Kirk Beitz CLA 2010-11-23 13:09:59 EST 
trivial: code cleanup
Comment 2 Jonah Graham CLA 2019-12-30 18:39:59 EST 
(this is part of a batch change)

The Eclipse CDT EDC (https://wiki.eclipse.org/CDT/cdt-debug-edc) is now obsolete and has not had any active development since 2011. Therefore the still open bugs are being marked as wontfix.

The git repo for the project still exists for posterity at https://git.eclipse.org/c/cdt/org.eclipse.cdt.edc.git/