Description Markus Keller 2010-11-23 10:59:18 EST

When I apply the patch from bug 36939 comment 70 to HEAD of org.eclipse.jdt.core and org.eclipse.jdt.core.tests.model, I'd expect an problem in org.eclipse.jdt.core.tests.model/plugin.xml: The file contains:

   <extension point="org.eclipse.jdt.core.compilationUnitProvider">
       <compilationUnitProvider file-extensions="foo"
           class="org.eclipse.jdt.core.tests.model.TestFooCompilationUnitProvider"/>
   </extension>

The class only implements ICompilationUnitProvider, but the declaration in compilationUnitProvider.exsd says:

         <attribute name="class" type="string" use="required">
            <annotation>
               <documentation>
                  the class that implements this container initializer.
         This class must implement a public subclass of &lt;code&gt;org.eclipse.jdt.core.ClasspathContainerInitializer&lt;/code&gt; with a public 0-argument constructor.
               </documentation>
               <appInfo>
                  <meta.attribute kind="java" basedOn="org.eclipse.jdt.core.ClasspathContainerInitializer"/>
               </appInfo>
            </annotation>
         </attribute> 

=> The "basedOn" attribute is set to ClasspathContainerInitializer.
=> TestFooCompilationUnitProvider doesn't extends that class, so there's a bug in the patch, but our tooling didn't detect it.

Bug 225121 sounds similar to this, but in N20101121-2000, I couldn't even get *any* problem for this.