330920 – [Dawn] Generated dawn editor ID has a space at the end

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 330920 - [Dawn] Generated dawn editor ID has a space at the end

Summary: [Dawn] Generated dawn editor ID has a space at the end

Status:	CLOSED FIXED

Alias:	None

Product:	EMF
Classification:	Modeling
Component:	cdo.dawn (show other bugs)
Version:	4.0
Hardware:	PC Windows 7

Importance:	P3 normal (vote)
Target Milestone:	---
Assignee:	Martin Fluegge
QA Contact:

URL:
Whiteboard:
Keywords:

Duplicates (1):	339660 (view as bug list)
Depends on:
Blocks:

Reported:	2010-11-23 09:35 EST by dloose Mising name
Modified:	2012-09-21 06:51 EDT (History)
CC List:	1 user (show)

See Also:

Attachments
Patch v1 (752 bytes, patch) 2011-05-09 17:13 EDT, Martin Fluegge	no flags	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description dloose Mising name

2010-11-23 09:35:40 EST

Build Identifier: 20100917-0705

I just generated the Dawn fragment from my .dawngenmodel file and was a bit frustrated when I found that the wizard it generated failed with a "unable to open editor, unknown editor id" error.

After scratching my head for far too long, I finally noticed that my generated Editor class had a space at the end of its ID constant. DawnDatabaseModelEditorUtil references that constant in the openDiagram method and, of course, the extension in fragment.xml does not have the space.

Reproducible: Always

Comment 1 Martin Fluegge

2011-05-09 04:46:30 EDT

Hi,

sorry, I must have overseen this bugzilla. 
Thanks for reporting. I'll care for is asap.

Cheers,

Martin

Comment 2 Martin Fluegge

2011-05-09 17:13:01 EDT

Created attachment 195152 [details]
Patch v1

Fixed the generator template.

Comment 3 Martin Fluegge

2011-05-09 17:13:31 EDT

Committed revision 7670:
- trunk/plugins/org.eclipse.emf.cdo.dawn.codegen.dawngenmodel.gmf

Comment 4 Martin Fluegge

2011-05-09 17:13:57 EDT

Patch v1 - Committed revision 7670

Comment 5 Martin Fluegge

2011-05-09 17:15:05 EDT

*** Bug 339660 has been marked as a duplicate of this bug. ***

Comment 6 Eike Stepper

2011-06-23 04:27:03 EDT

Moving all open problem reports to 4.0

Comment 7 Eike Stepper

2012-09-21 06:51:36 EDT

Closing.