Community
Participate
Working Groups
Build Identifier: 20100917-0705 Right now we are in the middle of developing some GEF based editor. The problem is - it hard to remove WikiText menu element from our editors context menu. There are two reasons for it: 1) It does contribute itself into popup:org.eclipse.ui.popup.any 2) It does not have any id specified so I could track it and remove from my contributor easily. So to avoid it appearing in the editor we need to instruct user to either remove Mylyn plugin or go into preferences and do some manipulations there, which is confusing. There should be something done there to avoid this situation, since WikiText does not have any sense for model files. Reproducible: Always
Thanks for the bug. The WikiText menu _should_ only appear for files that WikiText can work with... not sure why it's appearing on your editor. I'll look into this.
We are using XML (EMF) files with custom (*.am) extension. Looks like property tester for menu contribution is broken
Created attachment 183900 [details] Screenshot Attaching screenshot.
Created attachment 184419 [details] screenshot showing content types registry I'm having troubles reproducing here. Can you take a look at your content types and see if anything under wikitext would register against a file extension that you're using? You can see this in your preferences as shown in the attached screenshot
In case it helps i've added an id 'org.eclipse.mylyn.wikitext.ui.contextmenu' to the WikiText menu.
what version of Mylyn WikiText are you using?
I have the same configuration as you do. It is easy to reproduce - donwload eclipse from eclipse.org --- Eclipse IDE for Java Developers Version: Helios Service Release 1 Build id: 20100917-0705 --- I am using linux version eclipse-java-helios-SR1-linux-gtk.tar.gz - unpack it - run it on fresh workspace - create Java project with java file - Open java and right click it and it will be right there After tring to use "Generate Docbook" on Java file it will give error and turn off.
Created attachment 184437 [details] Sceenshot of mylin version
Created attachment 184438 [details] screenshot of menu element on Java file
sorry, didn't make it in time for this release. resetting target milestone
might still be possible to get this one in, it should just be a fix to the enablement expression. I'll take another look.
Created attachment 190903 [details] patch that fixes the issue The problem was that we were using a property tester that required plug-in activation. The attached patch removes the FilePropertyTester class and instead uses org.eclipse.core.resources.contentTypeId with kindOf argument. Tested and it has the desired behaviour. Steffen, can you take a look? It would be great to get this in the build.
Created attachment 190904 [details] mylyn/context/zip
The patch looks great. Please go ahead and apply and we can then do some testing on older versions of Eclipse.
changes pushed. Let's discuss a test plan.
I did some quick testing on 3.4 and 3.5 with the latest weekly build and the WikiText menu did not show for textile or mediawiki files any longer. It still works on Eclipse 3.6 and 3.7 though.
Thanks Steffen. I'll see if there's something that can be done about 3.5 and 3.4.
Closing. Release build is under way. We can consider a fix for Eclipse 3.4/3.5 for WikiText 1.4.1 or 1.5 if needed.
