Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 330875 - Use of Parenthesis in Stack Frame Name
Summary: Use of Parenthesis in Stack Frame Name
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-debug-dsf (show other bugs)
Version: 7.0   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 8.0   Edit
Assignee: Ken Ryall CLA
QA Contact: Pawel Piech CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-23 00:21 EST by Ken Ryall CLA
Modified: 2011-01-13 09:23 EST (History)
2 users (show)

See Also:
marc.khouzam: review+

Attachments
don't double parens (11.58 KB, patch)
2010-11-23 00:21 EST, Ken Ryall CLA 		ken.ryall: iplog-
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ken Ryall CLA 2010-11-23 00:21:44 EST 
Created attachment 183628 [details]
don't double parens

StackFrameVMNode's label provider adds "()" at the end of the function name for a stack frame. This is handy unless the function name provided already includes parenthesis. This can happen when the function name includes the full C++ function signature as in:

CActiveScheduler::Start(CActiveScheduler::TLoop**)

Currently you end up with:

CActiveScheduler::Start(CActiveScheduler::TLoop**)()

This patch continues the existing behavior by default but skips adding the "()" if the function name already contains "("

I would like to fix this for 7.0.x and 8.0, the 7.0.x patch will be slightly different because MessagesForLaunchVM.properties was renamed.
Comment 1 Marc Khouzam CLA 2010-11-23 15:14:59 EST 
Looks good to me
Comment 3 Ken Ryall CLA 2011-01-13 08:23:42 EST 
Committed to both branches.