Community
Participate
Working Groups
I was unable to commit a file in the org.eclipse.ui.forms project today, I got an error from CVS The server reported an error while performing the "cvs commit" command. org.eclipse.ui.forms: cvs [commit aborted]: could not open lock file `/cvsroot/eclipse/org.eclipse.ui.forms/META-INF/,MANIFEST.MF,': Permission denied I have the same problem with org.eclipse.ui.browser I'm guessing this has something to do with the recent changes to committer groups. Up until recently I was able to commit to org.eclipse.ui.browser and all three ui forms projects: org.eclipse.ui.forms, org.eclipse.ui.tests.forms and org.eclipse.ui.forms.examples.
Chris, /cvsroot/eclipse/org.eclipse.ui.forms is owned by the eclipse.platform.ui group, and you're not a member of that group according to John's latest spreadsheet in bug 324772 comment 50. Perhaps this was just an oversight... John, can you confirm? Here are Chris' group memberships: cgoldthor Groups (2): common,eclipse.platform.ua
In stating the obvious, all the other org.eclipse.ui* directories are owned by the same eclipse.platform.ui group.
(In reply to comment #2) > /cvsroot/eclipse/org.eclipse.ui.forms is owned by the eclipse.platform.ui > group, and you're not a member of that group according to John's latest > spreadsheet in bug 324772 comment 50. > > Perhaps this was just an oversight... John, can you confirm? > > Here are Chris' group memberships: > cgoldthor Groups (2): common,eclipse.platform.ua Yes this was my oversight. ui.forms and ui.browser previously had their own unique Unix groups. As part of the cleanup they were merged into Eclipse Platform UI. However because of this, Chris should have been added as a commiter on eclipse.platform.ui. Chris, I have nominated you as an eclipse.platform.ui committer. As penance for my screw up, I will happily commit any patches for you until the election completes. Did I miss any other active contributors to forms and browser? Unfortunately those groups are now gone so I can't see who else previously had access to them.
I am the only person who has been an active committer on org.eclipse.ui.forms in the last two years. Before that the most recent active committer was Adam Archer, followed by Curtis D'Entrement and Dejan Glozic. I just checked with all three and none of them needs commit rights to org.eclipse.ui.browser or org.eclipse.ui.forms.
> Chris, I have nominated you as an eclipse.platform.ui committer. As penance for Wayne, do we really need to go through the nomination/election process for these oversights?
(In reply to comment #5) > > Chris, I have nominated you as an eclipse.platform.ui committer. As penance for > > Wayne, do we really need to go through the nomination/election process for > these oversights? It's easier on Sharon. But process-wise, I don't care.
It seems that there are two possible ways to resolve this - one is to give me commit rights to Platform UI and the other is to change the CVS permissions of these few projects so that they are part of the User Assistance group. I'm happy with either solution. The projects org.eclipse.ui.browser and org.eclipse.ui.forms have been part of the user assistance project for mainly historic reasons but Platform UI may be a more logical fit. Assuming these projects stay in Platform UI and I am granted commit rights to Platform UI I see several consequences. 1. I have commit rights to some new projects - I don't plan to commit to those projects so this is a non issue. 2. Anyone in the platform UI team can commit to ui.forms or ui.browser - I can't imagine this causing any problems. 3. Some people who previously had commit rights to ui.browser and ui.forms no longer have them, specifically Chris Austin and Hao HH Zhang. 4. I temporarily have no commit rights to a few projects. Consequence 3 is the only one which needs more discussion - neither Chris Austin nor Hao Zhang has worked in either of these projects however they may end up running the release tool on the UA projects and without commit rights to all projects not all projects would get released and they would have to get someone with commit rights to Platform UI to release the remaining projects. I think we can live with this. In summary now that we have started down the road of adding me as a committer to Platform UI it is probably least disruptive to continue down that path but I'm fine with whatever everyone else decides to do.
(In reply to comment #7) > Consequence 3 is the only one which needs more discussion - neither Chris > Austin nor Hao Zhang has worked in either of these projects however they may > end up running the release tool on the UA projects and without commit rights to > all projects not all projects would get released and they would have to get > someone with commit rights to Platform UI to release the remaining projects. I > think we can live with this. If Chris A or Hao do start contributing to those projects then commit rights can easily be granted for it. The remaining case is that they are not committers, but they may be delegated releng duties? If that becomes an issue we could ask the Platform UI committer on releng duty to include those two in the projects they tag. In fact if it's just an occasional thing then I could do it too - I tag several projects I own every week, so a couple extra wouldn't hurt.
Chris, are we good here? I'll assume so.. Please reopen if we're missing something.
Yes, we are good.
Setting state to VERIFIED, I have had write access to those projects for some time now.
