Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 330862 - Add jetty adaptor to serverAdapterSites.xml
Summary: Add jetty adaptor to serverAdapterSites.xml
Status: RESOLVED FIXED
Alias: None
Product: WTP ServerTools
Classification: WebTools
Component: wst.server (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 major (vote)
Target Milestone: 3.2.4   Edit
Assignee: Angel Vera CLA
QA Contact: Angel Vera CLA
URL:
Whiteboard: PMC_approved
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-22 17:00 EST by Jesse McConnell CLA
Modified: 2014-12-13 03:17 EST (History)
1 user (show)

See Also:
david_williams: pmc_approved+
arvera: pmc_approved? (raghunathan.srinivasan)
arvera: pmc_approved? (naci.dai)
arvera: pmc_approved? (deboer)
arvera: pmc_approved? (neil.hauge)
arvera: pmc_approved? (kaloyan)
arvera: pmc_approved? (cbridgha)


Attachments
exception from 1st URL (9.86 KB, text/plain)
2010-12-07 11:48 EST, Angel Vera CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse McConnell CLA 2010-11-22 17:00:21 EST
discussed with angel vera... opening issue here

http://download.eclipse.org/jetty/updates/jetty-wtp

That is the url of the jetty wtp plugin.  It is a composite p2 repo so we can make releases behind the scenes and not influence the url...

we also have the CI publishing to http://download.eclipse.org/jetty/updates/jetty-wtp/development but I suspect that is not something that you would want to expose to the wst discovery...unless you have some cutting edge version of things that people were used to using, then we could tie into that.

I am working on getting the docs into the wiki now before we officially release the plugin but I figured I would get you the url now.
Comment 1 Angel Vera CLA 2010-12-07 11:48:10 EST
Created attachment 184732 [details]
exception from 1st URL

Jesse, 

I try adding: http://download.eclipse.org/jetty/updates/jetty-wtp

but nothing showed up in the additional servers, so I then tried your URL using the 'Help' -> 'Install New Software' and it didn't work either. For that I got the following attached exception.
Comment 2 Jesse McConnell CLA 2010-12-07 12:56:20 EST
odd, it installed correctly into eclipse

I'll dig into it a bit more
Comment 3 Jesse McConnell CLA 2010-12-10 15:59:21 EST
Can you give it another whirl?  I just deployed a new release of the plugin and updated the composite repository xml files...

It installed fine into a clean eclipse instance for me as well.

cheers,
jesse
Comment 4 Angel Vera CLA 2011-04-19 17:14:50 EDT
changes committed to HEAD (3.3)
Comment 5 Angel Vera CLA 2011-04-19 17:16:27 EDT
Jesse, I have committed the changes to 3.3 but I am still not seeing the server under the download additional adapters section, adding the URL doesn't hurt the framework, thus I have added. But your server still doesn't show. We can continue the investigation of it by email, I would suggest creating a bug on your side to track down the problem.
Comment 6 Angel Vera CLA 2011-04-19 17:24:05 EDT
* Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such. 
Without this change the server adapter won't be available through the "download additional adapter" ui

* Is there a work-around? If so, why do you believe the work-around is insufficient? 
Yes, but is a bit convoluted for the user. 

* How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added? 
I tested that eventhough the URL is not working, it doesn't affect any other function and the product is still usable, once the URL becomes active the server should be available and downloadable as any of the other servers.

* Give a brief technical overview. Who has reviewed this fix? 
The change is just adding a URL to a xml file

* What is the risk associated with this fix? 
The worst it can happen is that the XML is no in the right format, but I have checked that the URL is proper format and the loading of the xml still works and all the other URLs (for the other server adapters) are still working
Comment 7 David Williams CLA 2011-04-19 22:05:31 EDT
I'm assuming the URL and changes on our end are correct, and expect teams to work together to make sure it displays correctly. 

Thanks!
Comment 8 Angel Vera CLA 2011-04-19 22:10:01 EDT
Changes committed to 32M
Comment 9 Angel Vera CLA 2011-04-19 22:11:22 EDT
Changes released to 32M