Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 330858 - AbstractBasicTextPropertySection's TextChangeHelper doesn't handle "modify" events properly
Summary: AbstractBasicTextPropertySection's TextChangeHelper doesn't handle "modify" e...
Status: RESOLVED FIXED
Alias: None
Product: GMF-Runtime
Classification: Modeling
Component: General (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 major
Target Milestone: 1.4.2   Edit
Assignee: Anthony Hunter CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-22 16:19 EST by Wayne CLA
Modified: 2010-11-29 12:00 EST (History)
1 user (show)

See Also:

Attachments
Patch to fix the problem (2.86 KB, patch)
2010-11-22 16:19 EST, Wayne CLA 		ahunter.eclipse: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wayne CLA 2010-11-22 16:19:11 EST 
Build Identifier: GMF 1.4.0

The "Modify" event is not handled by the listener.  Instead, it treats "Keydown" events as modification.  This is incorrect, as simply pressing the Shift key when the field has focus results in the modification flag being set.  Second, it does not treat copy / paste using the mouse as modification because it is only checking for "Keydown" events.  Attached a patch to resolve the issue.  Alex Boyko has reviewed the patch.

Reproducible: Always
Comment 1 Wayne CLA 2010-11-22 16:19:56 EST 
Created attachment 183609 [details]
Patch to fix the problem
Comment 2 Anthony Hunter CLA 2010-11-29 12:00:30 EST 
Committed to R1_4_maintenance and HEAD.