Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 330856 - Outline view updates very slowly for large diagrams
Summary: Outline view updates very slowly for large diagrams
Status: RESOLVED FIXED
Alias: None
Product: GMF-Runtime
Classification: Modeling
Component: General (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 major
Target Milestone: 1.4.2   Edit
Assignee: Anthony Hunter CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-22 16:11 EST by Wayne CLA
Modified: 2010-11-29 11:59 EST (History)
1 user (show)

See Also:


Attachments
Patch to fix the problem (2.59 KB, patch)
2010-11-22 16:12 EST, Wayne CLA
ahunter.eclipse: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wayne CLA 2010-11-22 16:11:14 EST
Build Identifier: GMF 1.4.0

The outline view updates very slowly for large diagrams.  The tile size is hardcoded at 256x256, resulting in a huge number of tiles for large diagrams.  Please see the attached patch which has been reviewed by Alex Boyko.

Reproducible: Always
Comment 1 Wayne CLA 2010-11-22 16:12:37 EST
Created attachment 183604 [details]
Patch to fix the problem
Comment 2 Anthony Hunter CLA 2010-11-29 11:40:43 EST
Committed to R1_4_maintenance and HEAD.

Additional Notes from Wayne:
I am still unable to reproduce the 100% usage on my machine, but I have a good idea of what it is.  I plan to try a patch on Brian's system tomorrow to be absolutely certain the proposed fix does indeed resolve the issue.

The Outline view updates very slowly (after several minutes, I stopped waiting) for the large diagram in Brian's sample.  The problem is the tile size is hardcoded to 256x256.  In Brian's example, that resulted in 141 horizontal tiles and 347 vertical tiles = a total of 48927 tiles!  Now I restrict the number of tiles and the operation completes in 16 sec.

and

I generated a feature patch and Brian let me test it on his machine, where the CPU used to be stuck at 100% when showing the outline diagram.

With the patch installed, the outline diagram rendered much faster and the CPU usage dropped back to 1 - 2 % afterwards.

Thus, I can confirm that the fix resolves the issue.