Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 330840 - WTP-JUNIT_HeaderParserTests.runEAR50Test() assertions should be different for EAR with and whitout deployment descriptor.
Summary: WTP-JUNIT_HeaderParserTests.runEAR50Test() assertions should be different for...
Status: RESOLVED FIXED
Alias: None
Product: WTP Java EE Tools
Classification: WebTools
Component: jst.j2ee (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 3.2.3   Edit
Assignee: Salvador Zalapa CLA
QA Contact: Chuck Bridgham CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-22 13:54 EST by Salvador Zalapa CLA
Modified: 2011-01-10 11:01 EST (History)
1 user (show)

See Also:
jsholl: review+

Attachments
Adding an boolean extra field and modifing some assertions. (3.48 KB, patch)
2010-11-22 13:56 EST, Salvador Zalapa CLA 		ccc: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Salvador Zalapa CLA 2010-11-22 13:54:26 EST 
Build Identifier: 

In WTP test HeaderParserTests(found in org.eclipse.wtp.j2ee.headless.tests.j2ee.operations), the test testEAR50Import_NoDD is falling due to the JavaEEQuickPeek object gotten from an EAR archive version 5.0 without deployment descriptor is version 6.0 ( see org.eclipse.jst.j2ee.internal.archive.JavaEEArchiveUtilities.refine() from line 528). I think that HeaderParserTests.runEAR50Test() method should be more flexible for this issue. I suggest to add a boolean attribute to the internal class TesData to indicate if the archive has deployment descriptor and modify the method runEAR50Test() assertions regarding if the ear do have or does not deployment descriptor.   

Reproducible: Always
Comment 1 Salvador Zalapa CLA 2010-11-22 13:56:19 EST 
Created attachment 183591 [details]
Adding an boolean extra field and modifing some assertions.
Comment 2 Jason Sholl CLA 2010-11-23 09:27:08 EST 
Code checked into 32M and HEAD for WTP 3.2.3 and 3.3