Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 330828 - bundleInstallArtifactTreeFactory osgi service is registered twice in kernel.deployer
Summary: bundleInstallArtifactTreeFactory osgi service is registered twice in kernel.d...
Status: CLOSED FIXED
Alias: None
Product: Virgo
Classification: RT
Component: unknown (show other bugs)
Version: 2.2.0.M01   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.0.0.M01   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-22 11:53 EST by Dmitry Sklyut CLA
Modified: 2011-02-28 10:23 EST (History)
1 user (show)

See Also:

Attachments
patch (1.18 KB, patch)
2010-11-22 12:17 EST, Dmitry Sklyut CLA 		glyn.normington: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Sklyut CLA 2010-11-22 11:53:48 EST 
Build Identifier: 2.2.0 (master branch)

Found in: kernel/org.eclipse.virgo.kernel.deployer/src/main/resources/META-INF/spring/deployer-context.xml

First registration is on line 255:
	<!--  basic artifact type factories -->
	<service
		interface="org.eclipse.virgo.kernel.install.artifact.InstallArtifactTreeFactory"
		ref="bundleInstallArtifactTreeFactory" />

Second is on line 278:
	<service ref="bundleInstallArtifactTreeFactory"
		interface="org.eclipse.virgo.kernel.install.artifact.InstallArtifactTreeFactory" />

I have not seen this to cause an issue so far.  I think one of the service registrations should be removed.

Reproducible: Always
Comment 1 Glyn Normington CLA 2010-11-22 12:10:23 EST 
Nice catch! I agree we should delete one of these service elements.
Comment 2 Dmitry Sklyut CLA 2010-11-22 12:17:28 EST 
Created attachment 183580 [details]
patch

I wrote 100% of the code and have rights to contribute this code to Eclipse
Comment 3 Glyn Normington CLA 2010-11-23 04:35:44 EST 
Thanks for the patch! Applied at commit 7c06ccd77ef17868710c90e0d3ea7988ac17b3bf and pushed.