Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 330825 - Add new methods to interfaces that were tagged as @noimplement but for which the restriction has been removed is not a breaking change
Summary: Add new methods to interfaces that were tagged as @noimplement but for which ...
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: API Tools (show other bugs)
Version: 3.7   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 3.7 M4   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-22 11:32 EST by Olivier Thomann CLA
Modified: 2010-11-25 12:12 EST (History)
1 user (show)

See Also:
Michael_Rennie: review+

Attachments
Proposed fix + regression tests (8.79 KB, patch)
2010-11-22 11:51 EST, Olivier Thomann CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Thomann CLA 2010-11-22 11:32:40 EST 
Using HEAD, if an interface restriction is relaxed (@noimplement is removed) and at the same time a new method is added, this is reported as a breaking change.
This is not strictly speaking a breaking change since no clients are supposed to implement this interface. Therefore removing the restriction makes it possible to add new methods.
Of course existing implementations which are local to the bundle need to be updated.
Comment 1 Olivier Thomann CLA 2010-11-22 11:51:00 EST 
Created attachment 183578 [details]
Proposed fix + regression tests

All tests passed.
Michael, please review.
Comment 2 Michael Rennie CLA 2010-11-25 11:22:42 EST 
+1 all unit and smoke tests pass. Applied to HEAD.