Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 330745 - BFParserFactory causes unnecessary overhead on profiling data parser critical path
Summary: BFParserFactory causes unnecessary overhead on profiling data parser critical...
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: TPTP (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: Jonathan West CLA
QA Contact: Kathy Chan CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-20 14:03 EST by Jonathan West CLA
Modified: 2016-05-05 11:09 EDT (History)
3 users (show)

See Also:


Attachments
Patch to BFParser (7.40 KB, patch)
2010-11-20 14:07 EST, Jonathan West CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan West CLA 2010-11-20 14:03:51 EST
The BFParserFactory class is used to obtain an instance of ParserImpl1 (which implements BFParser). In doing so, both BFParserFactory and ParserImpl1 contain a fair number of unnecessary object instantiations and hashmap insertions. Unfortunately, this code is being called every single time data is received from a profiling agent to be parsed, thus increasing overhead due to the workbench code being on the parsing critical path.

Fix is use a single instance of ParseImpl1 and reset its state as needed.
Comment 1 Jonathan West CLA 2010-11-20 14:07:55 EST
Created attachment 183525 [details]
Patch to BFParser
Comment 2 Jonathan West CLA 2010-11-20 14:09:26 EST
Patch checked into HEAD.
Comment 3 Jonathan West CLA 2010-11-20 14:09:41 EST
Resolving.
Comment 4 Kathy Chan CLA 2011-02-11 13:45:56 EST
This defect had been resolved as FIXED for more than 1 month.  Please verify with the latest TPTP 4.7.2 driver.  If this defect is still left unverified by February 25, we'll close it on the originator's behalf.

TPTP 4.7.2 driver can be downloaded from:

http://www.eclipse.org/tptp/home/downloads/?ver=4.7.2
Comment 5 Jonathan West CLA 2011-04-01 14:24:00 EDT
Closing.