Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 330742 - Profiling data written to outgoing socket is unbuffered
Summary: Profiling data written to outgoing socket is unbuffered
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: TPTP (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P2 critical (vote)
Target Milestone: ---   Edit
Assignee: Jonathan West CLA
QA Contact: Kathy Chan CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-20 13:30 EST by Jonathan West CLA
Modified: 2016-05-05 10:48 EDT (History)
4 users (show)

See Also:


Attachments
Patch to Socket TL (12.26 KB, patch)
2010-11-20 13:40 EST, Jonathan West CLA
no flags Details | Diff
Patch to SocketListener.h for Solaris 64 (1013 bytes, patch)
2010-12-07 13:36 EST, Jonathan West CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan West CLA 2010-11-20 13:30:45 EST
Profiling data written to the outgoing socket, from the agent controller to the workbench, is currently unbuffered. This means that 20,000-25,000 single 100-byte messages per second are being sent out one-at-a-time, rather than together. This imposes a major performance penalty on profiling overhead and workbench processing speeds.

Fix is to wait for a certain amount of data to be available, and write it all at once, rather than writing each message separately. This also requires us to maintain a thread which ensures that data will not wait longer than a fixed amount to be sent.
Comment 1 Jonathan West CLA 2010-11-20 13:40:24 EST
Created attachment 183524 [details]
Patch to Socket TL
Comment 2 Jonathan West CLA 2010-11-20 13:45:28 EST
Resolving.
Comment 3 Jonathan West CLA 2010-12-07 13:34:34 EST
Reopening
Comment 4 Jonathan West CLA 2010-12-07 13:36:03 EST
Created attachment 184743 [details]
Patch to SocketListener.h for Solaris 64
Comment 5 Jonathan West CLA 2010-12-07 13:36:48 EST
Patch checked into HEAD.
Comment 6 Kathy Chan CLA 2011-02-11 13:46:30 EST
This defect had been resolved as FIXED for more than 1 month.  Please verify with the latest TPTP 4.7.2 driver.  If this defect is still left unverified by February 25, we'll close it on the originator's behalf.

TPTP 4.7.2 driver can be downloaded from:

http://www.eclipse.org/tptp/home/downloads/?ver=4.7.2
Comment 7 Jonathan West CLA 2011-04-01 14:24:08 EDT
Closing.