Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 330732 - Use Log to logging, do not use System.err in the BlockingChannelConnector
Summary: Use Log to logging, do not use System.err in the BlockingChannelConnector
Status: RESOLVED FIXED
Alias: None
Product: Jetty
Classification: RT
Component: server (show other bugs)
Version: unspecified   Edit
Hardware: PC All
: P3 minor (vote)
Target Milestone: 7.1.x   Edit
Assignee: Greg Wilkins CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-20 05:43 EST by KARASZI István CLA
Modified: 2010-11-21 18:07 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description KARASZI István CLA 2010-11-20 05:43:16 EST 
Build Identifier: 7.2.0.v20101020

Is there a reason to use the System.err to log messages instead of the Log interface?

In the checkIdleTimestamp() method at line #200 it prints out an IDLE message to the console when the client has been timed out. it would be better to use Log.debug() instead


Reproducible: Always
Comment 1 Greg Wilkins CLA 2010-11-20 17:49:56 EST 
ooops removed that r2546

Note that the SelectChannelConnector is better that BlockingChannelConnector in almost all situations.
Comment 2 KARASZI István CLA 2010-11-20 20:31:51 EST 
yes, you've told me and I've tested it in our environment for two weeks.

but BlockingChannelConnector uses much less CPU and responses faster. maybe because we have HAProxy instances before our Jetty instances. if you feel like I can provide you data or even an account.
Comment 3 Greg Wilkins CLA 2010-11-21 18:07:30 EST 
All usage is different, so if the blocking connector is working better for you than the selecting one - great.   That probably indicates that you have fewer more busy connections, while the select channel connector is optimized for many mostly idle connection.