Comment 1 John Arthorne 2010-11-19 17:19:17 EST

It appears the acls haven't been applied recursively. Here is a file in the releng project, note the lack of groups...


johna@dev1:/cvsroot/eclipse/org.eclipse.releng/maps> getfacl ui.map,v
# file: ui.map,v
# owner: kmoir
# group: eclipse.platform
user::rw-
user:kmoir:rwx
user:sdimitro:rwx
group::rwx
mask::rwx
other::r--

Comment 2 John Arthorne 2010-11-19 17:37:04 EST

I don't understand the pattern here, but the net result is that some people can commit and some can't. To give concrete examples, twatson and aniefer have been unable to commit anything under org.eclipse.releng. johna and pwebster were able to commit successfully.

Comment 3 Andrew Niefer 2010-11-19 17:43:16 EST

I also seem to be unable to commit to some other projects. 

The server reported an error while performing the "cvs commit" command.
org.eclipse.pde.build: cvs [commit aborted]: could not open lock file `/cvsroot/eclipse/pde/build/org.eclipse.pde.build/,build.properties,': Permission denied

Comment 4 Andrew Niefer 2010-11-19 17:56:42 EST

At this point it appears I can commit to things under /cvsroot/rt but not under /cvsroot/eclipse

Comment 5 Denis Roy 2010-11-22 08:59:01 EST

> johna@dev1:/cvsroot/eclipse/org.eclipse.releng/maps> getfacl ui.map,v
> # file: ui.map,v
> # owner: kmoir
> # group: eclipse.platform
> user::rw-
> user:kmoir:rwx
> user:sdimitro:rwx
> group::rwx
> mask::rwx
> other::r--


As I look this morning, on the same server, the ACLs look correct:

droy@dev1:/cvsroot/eclipse/org.eclipse.releng/maps> getfacl ui.map,v 
# file: ui.map,v
# owner: pwebster
# group: eclipse.platform
user::rw-
user:kmoir:rwx
user:sdimitro:rwx
group::rwx
group:eclipse.platform.debug:rwx
group:eclipse.platform.releng:rwx
group:eclipse.platform.resources:rwx
group:eclipse.platform.runtime:rwx
group:eclipse.platform.swt:rwx
group:eclipse.platform.team:rwx
group:eclipse.platform.text:rwx
group:eclipse.platform.ua:rwx
group:eclipse.platform.ui:rwx
group:eclipse.jdt:rwx
group:eclipse.jdt.core:rwx
group:eclipse.jdt.debug:rwx
group:eclipse.jdt.ui:rwx
group:eclipse.pde:rwx
group:eclipse.pde.build:rwx
group:eclipse.pde.incubator:rwx
group:eclipse.pde.ui:rwx
mask::rwx
other::r--


I'm sure Matt didn't fix this since he wasn't working when this bug reported.  We've configured NFS for fairly aggressive caching of file attributes, so depending on when the ACLs were put in place, it could have taken a while for all the servers to recognize them.

Please report back if (and where) commit problems are being seen.

Comment 6 John Arthorne 2010-11-22 09:22:01 EST

(In reply to comment #5)
> I'm sure Matt didn't fix this since he wasn't working when this bug reported. 
> We've configured NFS for fairly aggressive caching of file attributes, so
> depending on when the ACLs were put in place, it could have taken a while for
> all the servers to recognize them.

Here is what we are seeing:

 - Files that have not been touched since Matt did the change appear to be missing the groups, as in comment #1.
 - As soon as someone touches the file, the acls seem to get applied (as if they are getting pulled down from the parent file on write).
 - However some people are not able to touch the file when in this state.

For example see the acls of team.map or p2.map. They have not yet been touched since Matt's change so they don't have the ACL's populated. Some committers, such as aniefer, are not able to commit changes to these files.

Comment 7 Eclipse Webmaster 2010-11-22 09:50:26 EST

I've just 'touched' all of the files under org.eclipse.releng.  When this problem appeared did people restart their cvs connections?

-M.

Comment 8 Andrew Niefer 2010-11-22 11:00:59 EST

My commits seem to be working today.  I did restart my eclipse this morning based on comment #7

Comment 9 John Arthorne 2010-11-22 11:16:13 EST

(In reply to comment #7)
> I've just 'touched' all of the files under org.eclipse.releng.  When this
> problem appeared did people restart their cvs connections?

Great, this seems to have fixed the problem for org.eclipse.releng. The only other projects where we have multiple groups in the ACLs are org.eclipse.platform.doc.user and org.eclipse.platform.doc.isv. Should those projects also be "touched" to make sure the permission changes propagate?

Comment 10 Eclipse Webmaster 2010-11-22 13:15:51 EST

Done.

-M.

Comment 11 John Arthorne 2010-11-22 13:21:11 EST

(In reply to comment #10)
> Done.

Great! I will mark as closed and let you know if we find any other problems.