330693 – Improve suggested variable name in Extract Local Variable

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 330693 - Improve suggested variable name in Extract Local Variable

Summary: Improve suggested variable name in Extract Local Variable

Status:	RESOLVED FIXED

Alias:	None

Product:	CDT
Classification:	Tools
Component:	cdt-refactoring (show other bugs)
Version:	7.0
Hardware:	All All

Importance:	P3 enhancement (vote)
Target Milestone:	7.0.2
Assignee:	Emanuel Graf
QA Contact:	Emanuel Graf

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2010-11-19 13:00 EST by Marc-André Laperle
Modified:	2011-01-24 10:26 EST (History)
CC List:	2 users (show)

See Also:

Attachments
patch (2.50 KB, patch) 2011-01-04 07:17 EST, Emanuel Graf	emanuel: iplog-	Details \| Diff
Improved handling of long names (4.36 KB, patch) 2011-01-05 05:22 EST, Emanuel Graf	emanuel: iplog-	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Marc-André Laperle

2010-11-19 13:00:10 EST

A couple of things that should be improved:
- getField(), GetField(), isField() becomes getField, isField, it should be 'field'
- object->member->getField() becomes 'member,' it should be 'field'

Comment 1 Emanuel Graf

2011-01-04 07:17:02 EST

Created attachment 185996 [details]
patch

Comment 2 Emanuel Graf

2011-01-04 07:21:40 EST

Fixed in HEAD ans 7.0 >20110104

Comment 3 CDT Genie

2011-01-04 07:23:01 EST

*** cdt cvs genie on behalf of egraf ***
Bug 330693: Improve suggested variable name in Extract Local Variable
<a  href=https://bugs.eclipse.org/bugs/show_bug.cgi?id=330693>https://bugs.eclipse.org/bugs/show_bug.cgi?id=330693</a>

[*] ExtractLocalVariable.rts 1.8 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui.tests/resources/refactoring/ExtractLocalVariable.rts?root=Tools_Project&r1=1.7&r2=1.8

[*] ExtractLocalVariableRefactoring.java 1.12 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/refactoring/extractlocalvariable/ExtractLocalVariableRefactoring.java?root=Tools_Project&r1=1.11&r2=1.12

Comment 4 CDT Genie

2011-01-04 08:23:05 EST

*** cdt cvs genie on behalf of egraf ***
Bug 330693: Improve suggested variable name in Extract Local Variable
<a  href=https://bugs.eclipse.org/bugs/show_bug.cgi?id=330693>https://bugs.eclipse.org/bugs/show_bug.cgi?id=330693</a>

[*] ExtractLocalVariable.rts 1.3.6.4 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui.tests/resources/refactoring/ExtractLocalVariable.rts?root=Tools_Project&r1=1.3.6.3&r2=1.3.6.4

[*] ExtractLocalVariableRefactoring.java 1.7.2.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/refactoring/extractlocalvariable/ExtractLocalVariableRefactoring.java?root=Tools_Project&r1=1.7.2.1&r2=1.7.2.2

Comment 5 Marc-André Laperle

2011-01-04 19:22:48 EST

Thanks! This is much better. I noticed something while using it:

foo->getVarWithLongName() becomes 'name'. I think it should be varWithLongName. What do you think?

I think it should remove common prefixes, like get, get_, Get, Get_, lower the first letter after that and keep the rest of the string intact.

Comment 6 Emanuel Graf

2011-01-05 04:18:38 EST

(In reply to comment #5)
> Thanks! This is much better. I noticed something while using it:
> 
> foo->getVarWithLongName() becomes 'name'. I think it should be varWithLongName.
> What do you think?
> 
> I think it should remove common prefixes, like get, get_, Get, Get_, lower the
> first letter after that and keep the rest of the string intact.

Yeah your right that would be far better. I'll change this.

Comment 7 Emanuel Graf

2011-01-05 05:22:14 EST

Created attachment 186078 [details]
Improved handling of long names

Comment 8 CDT Genie

2011-01-05 05:23:03 EST

*** cdt cvs genie on behalf of egraf ***
bug 330693: Improve suggested variable name in Extract Local Variable
<a  href=https://bugs.eclipse.org/bugs/show_bug.cgi?id=330693>https://bugs.eclipse.org/bugs/show_bug.cgi?id=330693</a> Improved handling of long names

[*] ExtractLocalVariable.rts 1.3.6.5 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui.tests/resources/refactoring/ExtractLocalVariable.rts?root=Tools_Project&r1=1.3.6.4&r2=1.3.6.5

[*] ExtractLocalVariableRefactoring.java 1.7.2.3 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/refactoring/extractlocalvariable/ExtractLocalVariableRefactoring.java?root=Tools_Project&r1=1.7.2.2&r2=1.7.2.3

Comment 9 CDT Genie

2011-01-05 06:23:02 EST

*** cdt cvs genie on behalf of egraf ***
bug 330693: Improve suggested variable name in Extract Local Variable
<a  href=https://bugs.eclipse.org/bugs/show_bug.cgi?id=330693>https://bugs.eclipse.org/bugs/show_bug.cgi?id=330693</a> Improved handling of long names

[*] ExtractLocalVariableRefactoring.java 1.13 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/refactoring/extractlocalvariable/ExtractLocalVariableRefactoring.java?root=Tools_Project&r1=1.12&r2=1.13

[*] ExtractLocalVariable.rts 1.9 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui.tests/resources/refactoring/ExtractLocalVariable.rts?root=Tools_Project&r1=1.8&r2=1.9

Comment 10 Marc-André Laperle

2011-01-10 02:21:31 EST

Very nice! But I tested this for a couple of days and found another issue :) 

getFoo(getBar())

If I select the whole thing, 'bar' is suggested. Similarly, 

getFoo(getBar(getFooBar()))

fooBar is suggested. 

I haven't looked at the code closely but some AST magic is probably needed to make sure is gets the 'outer' call before doing string processing. I can open a separate bug if you like.

Comment 11 Marc-André Laperle

2011-01-24 10:26:21 EST

Opened bug 335202 the issue I mentioned.