Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 330658 - ECoreEditor cannot be used in RCP apps due to dependencies on org.eclipse.ui.ide
Summary: ECoreEditor cannot be used in RCP apps due to dependencies on org.eclipse.ui.ide
Status: CLOSED FIXED
Alias: None
Product: EMF
Classification: Modeling
Component: Tools (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Dave Steinberg CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-19 08:08 EST by Michael Spertus CLA
Modified: 2010-12-14 23:29 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Spertus CLA 2010-11-19 08:08:53 EST 
Build Identifier: 20100917-0705

I am generating an RCP project. Since my model references ecore.ecore, the generated ModelEditorAdvisor references org.eclipse.emf.ecore.presentation.EcoreEditor, which references org.eclipse.ui.ide.IGotoMarker, which certainly seems like it shouldn't be imported into an RCP application. When I posted on the EMF newsgroup, Ed Merks asked me to create a bugzilla


Reproducible: Always

Steps to Reproduce:
1. Create a model that reference ecore.ecore
2. Set the genmodel to create a RCP app
You should get an error that org.eclipse.ui.ide.IGotoMarker is indirectly referenced from required class files.
Comment 1 Ed Merks CLA 2010-11-19 08:54:20 EST 
The advisor should only referenced editors that are generated as part of the same plugin, not editors generated from used GenPackages from other GenModels.
Comment 2 Ed Merks CLA 2010-11-19 13:07:44 EST 
In particular, it looks like GenModel.getAllGenPackagesWithConcreteClasses shouldn't be returning any usedGenPackages.  I've committed the change for that for EMF 2.7.
Comment 3 Ed Merks CLA 2010-12-13 16:42:46 EST 
The fixes are available in a published build.
Comment 4 Ed Merks CLA 2010-12-14 23:28:08 EST 
Try again to resolve as fixed (and available in a build).
Comment 5 Ed Merks CLA 2010-12-14 23:29:45 EST 
Oh, I guess I have to close them!