Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 330609 - [Compatibility] 'Breakpoints' view's view menu's 'Group By' doesn't expand
Summary: [Compatibility] 'Breakpoints' view's view menu's 'Group By' doesn't expand
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.1   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: 4.2 M7   Edit
Assignee: Paul Webster CLA
QA Contact: Paul Webster CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-18 15:33 EST by Remy Suen CLA
Modified: 2012-05-01 13:58 EDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2010-11-18 15:33:31 EST 
There should be a 'Group By' submenu in the Ctrl+F10 menu but we only get raw text with no menu expansion in 4.x.
Comment 1 Remy Suen CLA 2011-10-14 10:59:18 EDT 
This is a very odd situation.

The submenu is implemented by a view action that's also a menu creator, that is, the class GroupBreakpointsByAction implements both IViewActionDelegate and IMenuCreator. This oddity allows the org.eclipse.debug.ui plug-in to contribute such a submenu to a view.

In 4.x, we transform the view action into a handled contribution item so the fact that the backing delegate actually implements IMenuCreator is completely ignored.

I don't think it's possible for us to know that the backing action implements the IMenuCreator interface at the moment so I'm not sure what we should do here.
Comment 2 Paul Webster CLA 2012-02-06 13:14:54 EST 
So they're getting the IMenuCreator call by the org.eclipse.ui.internal.ViewPluginAction in 3.x?

PW
Comment 3 Remy Suen CLA 2012-02-06 14:11:09 EST 
(In reply to comment #2)
> So they're getting the IMenuCreator call by the
> org.eclipse.ui.internal.ViewPluginAction in 3.x?

Trace as follows...

Daemon System Thread [Attach Listener] (Running)	
	GroupBreakpointsByAction.getMenu(Menu) line: 67	
	PluginActionContributionItem(ActionContributionItem).handleShowProxy(Menu) line: 1244	
	ActionContributionItem.access$4(ActionContributionItem, Menu) line: 1237	
	ActionContributionItem$8.handleEvent(Event) line: 1210	
	EventTable.sendEvent(Event) line: 84	
	Menu(Widget).sendEvent(Event) line: 1053	
	Menu(Widget).sendEvent(int, Event, boolean) line: 1077	
	Menu(Widget).sendEvent(int) line: 1058	
	Shell(Control).WM_INITMENUPOPUP(long, long) line: 4881	
	Shell(Control).windowProc(long, int, long, long) line: 4557	
	Shell(Canvas).windowProc(long, int, long, long) line: 341	
	Shell(Decorations).windowProc(long, int, long, long) line: 1627	
	Shell.windowProc(long, int, long, long) line: 2069	
	Display.windowProc(long, long, long, long) line: 4972	
	OS.TrackPopupMenu(long, int, int, int, int, long, RECT) line: not available [native method]	
	Menu._setVisible(boolean) line: 256	
	Display.runPopups() line: 4206	
	Display.readAndDispatch() line: 3748
Comment 4 Marc Khouzam CLA 2012-03-28 15:52:28 EDT 
Also affects CDT.
Comment 5 Michael Rennie CLA 2012-04-09 15:42:54 EDT 
(In reply to comment #4)
> Also affects CDT.

This is working as expected with the latest changes from master (which includes all of the changes from Paul's action set merges).

Mark / Pawel can you confirm if CDT is working again?
Comment 6 Marc Khouzam CLA 2012-04-09 15:50:53 EDT 
With I-build I20120321-0610, things look good for CDT.  Thanks!
Comment 7 Michael Rennie CLA 2012-04-09 16:52:36 EDT 
Thanks for reporting back Marc.

Marking fixed since this was covered with Paul's action set changes
Comment 8 Michael Rennie CLA 2012-05-01 13:58:11 EDT 
verified in

Version: 4.2.0
Build id: I20120430-1800