Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 330557 - Wrong analysis of tlds rtexprvalue in the JSP editor
Summary: Wrong analysis of tlds rtexprvalue in the JSP editor
Status: RESOLVED FIXED
Alias: None
Product: WTP Source Editing
Classification: WebTools
Component: jst.jsp (show other bugs)
Version: 3.2.2   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 3.2.3   Edit
Assignee: Nick Sandonato CLA
QA Contact: Nick Sandonato CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-18 07:47 EST by Daniel Le Berre CLA
Modified: 2010-11-19 14:35 EST (History)
1 user (show)

See Also:
thatnitind: review+

Attachments
patch (2.11 KB, patch)
2010-11-18 15:28 EST, Nick Sandonato CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Le Berre CLA 2010-11-18 07:47:06 EST 
The current editor wrongly warn the user that the parameter of a custom taglib cannot be a runtime expression when the <rtexprvalue> tag is set to yes.

Accepted values for that that are true/false/yes/no.

However, it looks like the editor only understands true/false, and consider values other than true as false.
Comment 1 Nick Sandonato CLA 2010-11-18 15:28:01 EST 
Created attachment 183421 [details]
patch

Validator used Boolean.valueOf() which returns false for "yes".
Comment 2 Daniel Le Berre CLA 2010-11-18 15:35:08 EST 
Thanks for the prompt action.
Comment 3 Nick Sandonato CLA 2010-11-19 14:35:09 EST 
(In reply to comment #2)
> Thanks for the prompt action.

You're welcome. Code has been checked in.