Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 330508 - EPartService's bringToTop(MPart) can cause part activation if placeholders are used
Summary: EPartService's bringToTop(MPart) can cause part activation if placeholders ar...
Status: VERIFIED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 1.0   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: 4.1 M4   Edit
Assignee: Remy Suen CLA
QA Contact: Remy Suen CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-17 14:23 EST by Remy Suen CLA
Modified: 2010-12-07 14:06 EST (History)
0 users

See Also:

Attachments
EPartService patch v1 (4.79 KB, patch)
2010-11-17 14:39 EST, Remy Suen CLA 		no flags Details | Diff
EPartService patch v2 (5.82 KB, patch)
2010-11-23 14:13 EST, Remy Suen CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2010-11-17 14:23:40 EST 
1. Activate the editor with a simple Java application in it.
2. Use 'F11' to start debugging it.
3. The 'Debug' view becomes the active part even though the focus is still on the editor. Keybindings like Ctrl+Left and Ctrl+Z will not work.
Comment 1 Remy Suen CLA 2010-11-17 14:28:28 EST 
Caused by the fix for bug 328078. Though the code was bad to begin with. It's just that the fix made it more prevalent.
Comment 2 Remy Suen CLA 2010-11-17 14:39:57 EST 
Created attachment 183334 [details]
EPartService patch v1
Comment 3 Remy Suen CLA 2010-11-17 14:40:34 EST 
(In reply to comment #2)
> Created an attachment (id=183334) [details]
> EPartService patch v1

Fix released to CVS HEAD.
Comment 4 Remy Suen CLA 2010-11-23 14:13:35 EST 
Created attachment 183701 [details]
EPartService patch v2

Found another problem that stemmed from trying to analyze placeholders instead of parts.
Comment 5 Remy Suen CLA 2010-11-23 14:14:53 EST 
(In reply to comment #4)
> Created an attachment (id=183701) [details]
> EPartService patch v2

Fix released to HEAD.
Comment 6 Remy Suen CLA 2010-12-07 14:06:40 EST 
Verified with I20101207-0250 on Windows XP.