Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 330483 - EAR Library Directory field should show a warning when empty
Summary: EAR Library Directory field should show a warning when empty
Status: RESOLVED FIXED
Alias: None
Product: WTP Java EE Tools
Classification: WebTools
Component: jst.j2ee (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows Vista
: P3 normal (vote)
Target Milestone: 3.2.3   Edit
Assignee: Aidyl Kareh CLA
QA Contact: Chuck Bridgham CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-17 12:08 EST by Aidyl Kareh CLA
Modified: 2010-11-22 09:19 EST (History)
3 users (show)

See Also:
cbridgha: review+

Attachments
Proposed Patch (8.27 KB, patch)
2010-11-17 12:12 EST, Aidyl Kareh CLA 		no flags Details | Diff
Additional Patch (1.20 KB, patch)
2010-11-20 09:19 EST, Aidyl Kareh CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aidyl Kareh CLA 2010-11-17 12:08:11 EST 
Build Identifier: WTP 3.2.3

The EAR Library Directory field in the 'Deployment Assembly' properties page should show a warning when the user leaves the field empty. An empty library directory field indicates that no library directory will be used when creating the class paths. The user should be warned so that they know that using an empty field is not equivalent to using the default lib folder nor using the root as a library directory. Also found that the error message for when the user precedes the Library Directory value with a slash is not covering the backslash scenario.

Reproducible: Always
Comment 1 Aidyl Kareh CLA 2010-11-17 12:12:31 EST 
Created attachment 183319 [details]
Proposed Patch

Patch uses the new problems view panel in the 'Deployment Assembly' properties page to show the new warning. The error message for when the user precedes the Library Directory value with a slash has also been updated to cover both back slash and forward slash.
Comment 2 Chuck Bridgham CLA 2010-11-17 15:11:29 EST 
approved.   I don't think you need PMC for this change because you already were approved for the messages pane earlier.  - This is simply a refinement of an existing message
Comment 3 Jason Sholl CLA 2010-11-18 10:46:16 EST 
Code checked into 32M and HEAD for WTP 3.2.3 and 3.3
Comment 4 Aidyl Kareh CLA 2010-11-20 09:19:48 EST 
Created attachment 183520 [details]
Additional Patch

The initial patch introduced a problem preventing the 'Deployment Assembly' properties page of legacy projects to open since the library directory field is not present. This patch now adds a null check for this scenario.
Comment 5 Aidyl Kareh CLA 2010-11-20 09:22:02 EST 
Reopening since additional patch is needed.
Comment 6 Jason Sholl CLA 2010-11-22 09:19:05 EST 
Additional patch checked into both 32M and HEAD for WTP 3.2.3 and 3.3