Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 330453 - [FastView] Should remove preferences related to fast views from preference pages
Summary: [FastView] Should remove preferences related to fast views from preference pages
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 1.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.5 M5   Edit
Assignee: Lars Vogel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 387291 441411 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-11-17 08:53 EST by Remy Suen CLA
Modified: 2015-01-28 10:38 EST (History)
6 users (show)

See Also:

Attachments
Remove fast views from preferences (78.80 KB, image/png)
2015-01-13 18:05 EST, Lars Vogel CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2010-11-17 08:53:25 EST 
In the 'Perspectives' preference page, there are some preferences for fast views there. Since fast views no longer exist in 4.x, these preferences should be deleted.
Comment 1 Dani Megert CLA 2014-08-08 05:48:17 EDT 
*** Bug 441411 has been marked as a duplicate of this bug. ***
Comment 2 Mauro Molinari CLA 2014-08-08 06:08:35 EDT 
Also the Eclipse Guide should be updated. It still describes the Fast View features as available, although obsolete.
Comment 3 Dani Megert CLA 2014-08-08 06:12:47 EDT 
*** Bug 387291 has been marked as a duplicate of this bug. ***
Comment 4 Lars Vogel CLA 2015-01-13 18:05:33 EST 
Created attachment 249916 [details]
Remove fast views from preferences
Comment 5 Lars Vogel CLA 2015-01-26 09:46:39 EST 
Denis posted a Gerrit review: https://git.eclipse.org/r/#/c/40280
Comment 6 Lars Vogel CLA 2015-01-26 09:54:48 EST 
(In reply to Lars Vogel from comment #5)
> Denis posted a Gerrit review: https://git.eclipse.org/r/#/c/40280

Thanks Denis, merged with http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=538cac16d9a7b620c39710725cb079687864c6ce

I think you can also remove several constants in IPreferencesConstants:

IPreferenceConstants.FVB_HIDE
IPreferenceConstants.OVM_EMBED
IPreferenceConstants.OPEN_VIEW_MODE
IPreferenceConstants.OVM_FLOAT (see PerspectivesPreferencePage line 385)

AFACS these settings relate only to Fast Views and are not used anymore (except the preference page and reset default preference handling).


Denis, can you provide a patch to remove these constants and their usage?
Comment 8 Lars Vogel CLA 2015-01-28 10:38:09 EST 
Validated in 4.5.0.I20150126-2000