Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 330451 - TimeoutException when switching branch for big model
Summary: TimeoutException when switching branch for big model
Status: CLOSED FIXED
Alias: None
Product: EMF
Classification: Modeling
Component: cdo.core (show other bugs)
Version: 4.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Pascal Lehmann CLA
QA Contact: Eike Stepper CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-17 08:43 EST by Pascal Lehmann CLA
Modified: 2011-06-23 03:39 EDT (History)
0 users

See Also:
stepper: review+

Attachments
Patch (12.95 KB, patch)
2010-11-17 08:48 EST, Pascal Lehmann CLA 		no flags Details | Diff
Patch v2 - ready to be committed (17.06 KB, patch)
2010-11-18 01:41 EST, Eike Stepper CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pascal Lehmann CLA 2010-11-17 08:43:32 EST 
We often get a TimeoutException on OfflineClone when switching the branch using a bigger model (~60'000 Objects, 25'000 loaded):

org.eclipse.emf.cdo.common.util.TransportException: java.util.concurrent.TimeoutException
	at org.eclipse.emf.cdo.internal.net4j.protocol.CDOClientProtocol.send(CDOClientProtocol.java:368)
	at org.eclipse.emf.cdo.internal.net4j.protocol.CDOClientProtocol.changeView(CDOClientProtocol.java:177)
	at org.eclipse.emf.internal.cdo.view.CDOViewImpl.setBranchPoint(CDOViewImpl.java:365)
Comment 1 Pascal Lehmann CLA 2010-11-17 08:48:30 EST 
Created attachment 183291 [details]
Patch

Patch changing the ChangeViewRequest to RequestWithMonitoring.
Comment 2 Eike Stepper CLA 2010-11-18 01:41:15 EST 
Created attachment 183364 [details]
Patch v2 - ready to be committed

I've factored out a CDOServerReadIndicationWithMonitoring on the server side.

And I've consolidated the monitoring send() methods in CDOClientProtocol:
private <RESULT> RESULT send(RequestWithMonitoring<RESULT> request, OMMonitor monitor)
Comment 3 Pascal Lehmann CLA 2010-11-18 03:10:36 EST 
Committed to HEAD.
Comment 4 Eike Stepper CLA 2011-06-23 03:39:21 EDT 
Available in R20110608-1407