Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 330418 - JSP support depends on a gaggle of jars that are not on maven central
Summary: JSP support depends on a gaggle of jars that are not on maven central
Status: CLOSED FIXED
Alias: None
Product: Jetty
Classification: RT
Component: other (show other bugs)
Version: unspecified   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: 7.1.x   Edit
Assignee: Jesse McConnell CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-16 20:54 EST by benson margulies CLA
Modified: 2011-01-07 11:25 EST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description benson margulies CLA 2010-11-16 20:54:16 EST
Build Identifier: 7.1.2.v20100523

In the 7.1.2 release, the lib/jsp directory contains the list that follows. I'm reasonably sure that *none* of these are on Maven Central, and I'm perfectly sure that ecj isn't, since I can find earlier versions on central.

This is a cruel prank to play on us maven embedders. Could you folks please make a practice of  pushing the dependencies to central, or perhaps shade up a combined jar and push it under your own group id? it would really be helpful to just add a dependency and get JSP pages to work.

com.sun.el_1.0.0.v201004190952.jar
ecj-3.6M7.jar
javax.el_2.1.0.v201004190952.jar
javax.servlet.jsp_2.1.0.v201004190952.jar
jetty-jsp-2.1-7.1.2.v20100523.jar
org.apache.jasper.glassfish_2.1.0.v201004190952.jar
org.apache.taglibs.standard.glassfish_1.2.0.v201004190952.jar

Failing this, an explanation on the Wiki would be nice ...

Reproducible: Always
Comment 1 Greg Wilkins CLA 2010-11-16 20:59:43 EST
benson,

hey we are doing the best we can and are constant advocates for ALL jars to be available in maven central.

But let me check the exact status of those jars and I'll respond in more detail soon.
Comment 2 Greg Wilkins CLA 2010-11-16 21:10:47 EST
You should be able to get JSP as a maven dependency by depending on org.eclipse.jetty:jetty-jsp-2.1, which has the following dependency tree:

[INFO] org.eclipse.jetty:jetty-jsp-2.1:jar:7.2.2-SNAPSHOT
[INFO] +- org.eclipse.jetty:jetty-util:jar:7.2.2-SNAPSHOT:provided
[INFO] +- org.mortbay.jetty:jsp-2.1-glassfish:jar:2.1.v20100127:provided
[INFO] |  +- org.eclipse.jdt.core.compiler:ecj:jar:3.5.1:provided
[INFO] |  +- org.mortbay.jetty:jsp-api-2.1-glassfish:jar:2.1.v20100127:provided
[INFO] |  \- ant:ant:jar:1.6.5:provided
[INFO] \- javax.servlet:servlet-api:jar:2.5:provided

which are available from maven:

http://repo2.maven.org/maven2/org/mortbay/jetty/jsp-2.1-glassfish/

The exact jars we ship in lib/jsp are a little different from these, because we need to ship versions that are IP cleared by eclipse foundation, and these are not available in maven - only orbit: http://download.eclipse.org/jetty/orbit/

We'll put an explanation on the wiki
Comment 3 benson margulies CLA 2010-11-16 21:30:27 EST
I don't see those dependencies on jetty-jsp-2.1 when I state it as a dependency.

The reason is that the dependencies are marked 'provided' in your POM, so they aren't inherited by things that state this artifact as a dependency.

It would be nice if there was 'something to depend on' (jetty-jsp-2.1-embedded, e.g.) that had these as plain dependencies. 

However, sure enough, adding this list to the wiki would have spared me.

Also, 'embedding' page points to the page that talks about start.jar, but start.jar is really not relevant to embedding.
Comment 4 Jesse McConnell CLA 2011-01-07 11:22:10 EST
I made a comment on the jetty embedding page about this.

also you ought to be able to depend on one of the aggregates and get the jsp support, if that doesn't work then its a legit bug we'll have to iron out as the aggregates are meant to give you a one stop shop for embedding.

http://repo2.maven.org/maven2/org/eclipse/jetty/aggregate/jetty-all-server/
Comment 5 benson margulies CLA 2011-01-07 11:25:57 EST
Did you remove the 'provided' notations, or add non-provided deps to the aggregates?

is the suggestion of http://repo2.maven.org/maven2/org/eclipse/jetty/aggregate/jetty-all-server/ to tell me to just depend on that instead of the smaller pieces I've been depending on so far?