Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 330389 - Prevent recursive focus requests in ContributedPartRenderer
Summary: Prevent recursive focus requests in ContributedPartRenderer
Status: VERIFIED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 1.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.1 M4   Edit
Assignee: Remy Suen CLA
QA Contact: Eric Moffatt CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-16 13:44 EST by Remy Suen CLA
Modified: 2010-12-08 09:15 EST (History)
0 users

See Also:

Attachments
ContributedPartRenderer patch v1 (2.14 KB, patch)
2010-11-16 13:44 EST, Remy Suen CLA 		no flags Details | Diff
ContributedPartRenderer patch v2 (3.73 KB, patch)
2010-11-16 14:30 EST, Remy Suen CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2010-11-16 13:44:54 EST 
Created attachment 183255 [details]
ContributedPartRenderer patch v1

It is currently possible to get into an infinite loop with the setFocus() code for delegating to @Focus. See bug 323808.
Comment 1 Remy Suen CLA 2010-11-16 14:30:22 EST 
Created attachment 183261 [details]
ContributedPartRenderer patch v2

Add logging.
Comment 2 Remy Suen CLA 2010-11-17 13:28:21 EST 
(In reply to comment #1)
> Created an attachment (id=183261) [details]
> ContributedPartRenderer patch v2

Fix released to CVS HEAD.
Comment 3 Remy Suen CLA 2010-12-08 09:15:55 EST 
Verified that RSE doesn't crash with I20101208-0250 on Windows XP and that a warning is logged.