Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 330294 - RCP SDK does not contain executable feature
Summary: RCP SDK does not contain executable feature
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Releng (show other bugs)
Version: 3.6.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.7 M5   Edit
Assignee: Kim Moir CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-15 17:16 EST by Tillmann Seidel CLA
Modified: 2010-12-21 17:21 EST (History)
2 users (show)

See Also:

Attachments
patch (944 bytes, patch)
2010-12-14 11:57 EST, Kim Moir CLA 		no flags Details | Diff
patch (959 bytes, patch)
2010-12-20 17:41 EST, Kim Moir CLA 		no flags Details | Diff
patch (946 bytes, patch)
2010-12-21 17:20 EST, Kim Moir CLA 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tillmann Seidel CLA 2010-11-15 17:16:31 EST 
Build Identifier: Version: 3.6.1 Build id: M20100909-0800

The RCP SDK archive available for download is supposed to contain the delta pack. However it only contains the fragments but not the org.eclipse.equinox.executable feature.

I see the main purpose of the RCP SDK archive to serve as a target platform for RCP development. But though it is supposed to contain the delta pack, PDE tooling does not offer cross-platform exports since it searches for the executable feature in the target.

Either the feature should be added or the delta pack fragments should be removed entirely.

Reproducible: Always
Comment 1 Kim Moir CLA 2010-11-16 09:37:13 EST 
It looks like it includes the executable feature.  

-bash-3.00$ unzip -l eclipse-3.6.1-delta-pack.zip  |grep feature | more
        0  09-09-10 11:44   eclipse/features/
        0  09-09-10 11:44   eclipse/features/org.eclipse.equinox.executable_3.4.1.R36x_v20100823-7M7K7JF90dnJ-WLf3cf4yi/
        0  09-09-10 11:44   eclipse/features/org.eclipse.equinox.executable_3.4.1.R36x_v20100823-7M7K7JF90dnJ-WLf3cf4yi/META-INF/
     5556  08-25-10 11:44   eclipse/features/org.eclipse.equinox.executable_3.4.1.R36x_v20100823-7M7K7JF90dnJ-WLf3cf4yi/META-INF/MANIFEST.MF
       76  08-25-10 11:44   eclipse/features/org.eclipse.equinox.executable_3.4.1.R36x_v20100823-7M7K7JF90dnJ-WLf3cf4yi/META-INF/eclipse.inf
     5677  08-25-10 11:44   eclipse/features/org.eclipse.equinox.executable_3.4.1.R36x_v20100823-7M7K7JF90dnJ-WLf3cf4yi/META-INF/ECLIPSEF.SF
     5639  08-25-10 11:44   eclipse/features/org.eclipse.equinox.executable_3.4.1.R36x_v20100823-7M7K7JF90dnJ-WLf3cf4yi/META-INF/ECLIPSEF.RSA
     9485  08-25-10 09:59   eclipse/features/org.eclipse.equinox.executable_3.4.1.R36x_v20100823-7M7K7JF90dnJ-WLf3cf4yi/feature.properties
Comment 2 Tillmann Seidel CLA 2010-11-16 09:42:48 EST 
The delta pack contains the feature.

But I was referring to the RCP SDK (org.eclipse.rcp.source-3.6.1.zip).
Comment 3 Kim Moir CLA 2010-11-17 16:52:32 EST 
Sorry, I misread the bug.  So, the purpose of the delta pack is to provide the platform specific bits. The rcp source zip just includes the components of the rcp feature.  The executables are, as you noted, included in a different feature that isn't included in the rcp feature.
Comment 4 Tillmann Seidel CLA 2010-11-18 04:05:30 EST 
The description of the RCP SDK says:

"This p2 repository consists of the Eclipse Rich Client Platform base bundles and their source and the RCP delta pack."

This is misleading - if it states that it contains the delta pack, I would expect that it not only contains the fragments but also the binaries. What's the use of having fragments of other platforms if you cannot build products?

My proposal is to either take the delta pack fragments out of the SDK (people can still add the delta pack to their target platform if they need it) or to add the binaries (and the feature) as well.
Comment 5 Kim Moir CLA 2010-11-22 16:20:03 EST 
Jeff, do you have any comments on whether the RCP repo zips should include the delta packs or not?
Comment 6 Jeff McAffer CLA 2010-11-22 16:32:35 EST 
See Bug 310737 and Bug 310739.  

at this point, yes, the RCP SDK zip should include the excutables.
Comment 7 Kim Moir CLA 2010-12-14 11:57:52 EST 
Created attachment 185150 [details]
patch
Comment 8 Kim Moir CLA 2010-12-20 17:41:37 EST 
Created attachment 185603 [details]
patch
Comment 9 Kim Moir CLA 2010-12-21 17:20:26 EST 
Created attachment 185677 [details]
patch
Comment 10 Kim Moir CLA 2010-12-21 17:21:22 EST 
Fixed for N20101221-2000.