Description Stephane fournier 2010-11-15 16:11:20 EST

Build Identifier: 0.7.8

When SVNTeamModificationValidator is called to validateEdit files controlled by subversive with SVN lock usage, SVNTeamModificationValidator#validateEdit(IFile[] files, final FileModificationValidationContext context) does not rely on LockProposeUtility.proposeLock(needsLockResources) to create the returned status.

Here is a possible fix, CANCEL_STATUS is returned if locks fails to be taken :

  public IStatus validateEdit(IFile[] files, final FileModificationValidationContext context) {
    IStatus resultingStatus = Status.OK_STATUS;
    if (FileUtility.isConnected(files[0])) {
      final IResource[] needsLockResources = this.getNeedsLockResources(files);
      if (needsLockResources.length > 0) {
        if (!LockProposeUtility.proposeLock(needsLockResources)){
          resultingStatus = Status.CANCEL_STATUS;
        }
      }
    }
    return resultingStatus;
  }



Reproducible: Always

Steps to Reproduce:
1.Make a change in a file controlled by SVN with lock enabled.
2. cancel the lock when the popup is prompted.

>> SVNTeamModificationValidator#validateEdit returns OK status.