Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 330266 - [ui] XML reload grammar / dependencies actions always visible
Summary: [ui] XML reload grammar / dependencies actions always visible
Status: RESOLVED FIXED
Alias: None
Product: WTP Source Editing
Classification: WebTools
Component: wst.xml (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3 M4   Edit
Assignee: Nick Sandonato CLA
QA Contact: Nitin Dahyabhai CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-15 11:56 EST by Nick Sandonato CLA
Modified: 2010-11-15 14:09 EST (History)
0 users

See Also:

Attachments
patch (8.19 KB, patch)
2010-11-15 11:57 EST, Nick Sandonato CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Sandonato CLA 2010-11-15 11:56:10 EST 
Bug 303379 introduced a new property tester that is used to identify when XML editors are active in order to always display these two actions. But, the property tester isn't being forced to activate the plug-in. This causes the icons to always be visible until the XML UI plug-in is loaded.
Comment 1 Nick Sandonato CLA 2010-11-15 11:57:53 EST 
Created attachment 183140 [details]
patch
Comment 2 Nitin Dahyabhai CLA 2010-11-15 12:25:56 EST 
Since the two commands don't actually reference the XMLMultiPageEditorPart class, is there any reason not to just test for the input's content type instead of a specific editor?
Comment 3 Nick Sandonato CLA 2010-11-15 14:09:12 EST 
We want to make sure that only editors that utilize are editor are endowed with this functionality.