Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 330259 - [disassembly] debug context is not per workbench window
Summary: [disassembly] debug context is not per workbench window
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-debug-dsf (show other bugs)
Version: 7.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 8.0   Edit
Assignee: Patrick Chuong CLA
QA Contact: Pawel Piech CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-15 10:46 EST by Patrick Chuong CLA
Modified: 2011-01-07 16:39 EST (History)
2 users (show)

See Also:
pchuong: iplog-

Attachments
patch - retrieves debug context per workbench window (4.18 KB, patch)
2010-11-15 10:48 EST, Patrick Chuong CLA 		no flags Details | Diff
new patch - retrives debug context and register listener per window service (5.71 KB, patch)
2010-11-16 10:05 EST, Patrick Chuong CLA 		pchuong: iplog-
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Chuong CLA 2010-11-15 10:46:22 EST 
When you open multiple workbench windows with multiple disassembly views open, than selecting the stackframe in one workbench windows causes the other workbench window's disassembly view to update as well.
Comment 1 Patrick Chuong CLA 2010-11-15 10:48:54 EST 
Created attachment 183126 [details]
patch - retrieves debug context per workbench window
Comment 2 Anton Leherbauer CLA 2010-11-16 03:14:50 EST 
Right, I tend to forget that there can be multiple windows.  I think we should also register the IDebugContextListener with the window-specific context service.
Comment 3 Patrick Chuong CLA 2010-11-16 10:05:48 EST 
Created attachment 183228 [details]
new patch - retrives debug context and register listener per window service

I intended to change the listener when I submit a view pin&clone patch to CDT, I guess this is a good fix for now. I'll have to change the addDebugListener to provide the view IDs later.

I also made an addition nullpointer fix in this patch, getTopAddress() causes a nullpointer when the view is close.
Comment 4 Patrick Chuong CLA 2010-11-24 09:42:09 EST 
I have commit the patch to head.
Comment 5 CDT Genie CLA 2010-11-24 10:23:05 EST 
*** cdt cvs genie on behalf of pchuong ***
Bug 330259 - [disassembly] debug context is not per workbench window

[*] DisassemblyPart.java 1.40 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf/org.eclipse.cdt.dsf.ui/src/org/eclipse/cdt/dsf/debug/internal/ui/disassembly/DisassemblyPart.java?root=Tools_Project&r1=1.39&r2=1.40