Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 330253 - [JEE Discoverer] JUnit test failure on Hudson
Summary: [JEE Discoverer] JUnit test failure on Hudson
Status: CLOSED FIXED
Alias: None
Product: MoDisco
Classification: Modeling
Component: Technologies (show other bugs)
Version: 0.9.0   Edit
Hardware: PC Windows XP
: P2 normal (vote)
Target Milestone: 0.9.0 M4   Edit
Assignee: Fabien Giquel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-15 09:45 EST by Nicolas Guyomar CLA
Modified: 2011-01-11 05:19 EST (History)
3 users (show)

See Also:
fabien.giquel: indigo+

Attachments
Patch for JEE Deployment Descriptor xml version retrieving (2.32 KB, patch)
2010-11-15 09:52 EST, Nicolas Guyomar CLA 		fabien.giquel: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nicolas Guyomar CLA 2010-11-15 09:45:14 EST 
Hi,

Tests for ejb-jar and webxml discoverers are failing on Hudson because some connection time out exceptions occurred while trying to get a DTD from sun server.

MoDisco Discoverer should not need an internet connection to work.

Here is a patch which determine the version of the discovered file without the need of a DTD

(a) I, Nicolas Guyomar, wrote 100% of the code of the contribution
(b) I have the right to contribute the code to Eclipse
(c) I want to contribute this code under EPL


Regards

Nicolas Guyomar
Comment 1 Nicolas Guyomar CLA 2010-11-15 09:52:32 EST 
Created attachment 183121 [details]
Patch for JEE Deployment Descriptor xml version retrieving

This patch uses a simple reader to determine the Doctype version of an xml file.
Comment 2 Fabien Giquel CLA 2010-11-16 03:24:18 EST 
Thks Nicolas,

Here is a contribution from an employee of Mia-Software, targeting future
Indigo release. The company has signed a Member Commiter Agreement. The
contribution does not need a CQ (see bug 322327).

The contribution has been commited into SVN (revision 3607)
Comment 3 Hugo Bruneliere CLA 2011-01-11 05:19:27 EST 
Bug fixed via a patch.