Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 330052 - Breakage related to sticky views
Summary: Breakage related to sticky views
Status: CLOSED FIXED
Alias: None
Product: EMF
Classification: Modeling
Component: cdo.core (show other bugs)
Version: 4.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Caspar D. CLA
QA Contact: Eike Stepper CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-11 23:25 EST by Caspar D. CLA
Modified: 2011-06-23 03:37 EDT (History)
3 users (show)

See Also:
stepper: review+

Attachments
Patch (15.34 KB, patch)
2010-11-11 23:43 EST, Caspar D. CLA 		no flags Details | Diff
Patch v2 - ready to be committed (15.63 KB, patch)
2010-11-13 03:54 EST, Eike Stepper CLA 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Caspar D. CLA 2010-11-11 23:25:37 EST 
Sticky views are broken in 2 ways:

1. The mechanism that excludes objects that were committed by the
sticky session, from stickiness, works on a per-transaction basis,
while it should work on a per-session basis. Result is that currently,
a view can't find an objects that was newly committed by a transaction
in the same session.

2. The sticky-or-not decision logic does not take into account that
the view requesting the revision might be an audit view; and so
audit-view behavior has been broken since the introduction of sticky
behavior.

Will provide testcases and patch shortly.
Comment 1 Caspar D. CLA 2010-11-11 23:43:32 EST 
Created attachment 182952 [details]
Patch

This patch moves much of the sticky logic from the view/tx to the
session, where it belongs (since stickiness is a session property),
and in addition it properly excludes audit view from sticky behavior.
Comment 2 Eike Stepper CLA 2010-11-13 03:54:34 EST 
Created attachment 183074 [details]
Patch v2 - ready to be committed

Just reformatted slightly.
Comment 3 Caspar D. CLA 2010-11-14 22:40:28 EST 
Committed to HEAD
Comment 4 Eike Stepper CLA 2011-06-23 03:37:17 EDT 
Available in R20110608-1407