Description Romain Raugi 2010-11-11 14:18:40 EST

Build Identifier: M20100909-0800

Hi,

Adding properties (IProperty) to PlatformGraphicsAlgorithm is a possibility to parameter the appearance of an implementation of IGraphicsAlgorithmRenderer. See https://bugs.eclipse.org/bugs/show_bug.cgi?id=326733.

A nicer approach is to extend the notational metamodel (with EMF) to subclass PlatformGraphicsAlgorithm and to add custom attributes. But there are two limitations at the refresh level:

- In DiagramChangeListener, the instructions line 118 to 121 prevent the renderers from being refreshed because the subsclass of PlatformGraphicsAlgorithm is in another package:

EPackage p = eo.eClass().getEPackage();
if (!(p instanceof PictogramsPackage || p instanceof AlgorithmsPackage || p instanceof StylesPackage || p instanceof MmPackage)) {
  continue;
}

- In PictogramElementDelegate, there is no refresh of the IGraphicsAlgorithmRenderer when the update concerns a PlatformGraphicsAlgorithm.

These two minor issues introduce an important limitation.


Reproducible: Always

Steps to Reproduce:
1. Run the example in attachment (thanks to the org.eclipse.graphiti.examples.common launcher - New > Examples > Graphiti > Graphiti Diagram, "example" diagram type).
2. Create a Rectangle.
3. Move the Rectangle. No refresh.
4. Right click on the Rectangle to display the popup menu. Set Custom Boolean Attribute. Then do not move the cursor. No refresh.